From: Kevin Buettner <kevinb@redhat.com>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix quoting in gdb-add-index.sh
Date: Thu, 12 Sep 2024 22:03:36 -0700 [thread overview]
Message-ID: <20240912220336.1a2afc89@f40-zbm-amd> (raw)
In-Reply-To: <20240911143426.3040211-1-tromey@adacore.com>
On Wed, 11 Sep 2024 08:34:26 -0600
Tom Tromey <tromey@adacore.com> wrote:
> When the filename quoting change was merged into the AdaCore tree, we
> saw a regression in a test setup that uses the DWARF 5 index (that is
> running gdb-add-index), and a filename with a space in it.
>
> Initially I thought this was a change in the 'file' command -- but
> looking again, I found out that 'file' has worked this way for a
> while, and our immediate error was caused by the (documented) change
> to "save gdb-index".
>
> While I'm not sure why this test was working previously, it seems to
> me that gdb-add-index.sh requires a change to quote the arguments to
> "file" and "save gdb-index".
>
> While working on this, though, it seemed to me that multiple other
> spots needed quoting for the script to work correctly. And, I was
> unable to get quoting working correctly in the objcopy calls, so I
> split it into multiple different invocations.
FWIW, I think it's now easier to read with separate invocations.
Approved-by: Kevin Buettner <kevinb@redhat.com>
prev parent reply other threads:[~2024-09-13 5:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 14:34 Tom Tromey
2024-09-13 5:03 ` Kevin Buettner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240912220336.1a2afc89@f40-zbm-amd \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox