From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id vAWyH8PH42YycCkAWB0awg (envelope-from ) for ; Fri, 13 Sep 2024 01:04:03 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=RyxPFIJl; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5B3B51E353; Fri, 13 Sep 2024 01:04:03 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-12.8 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE,URIBL_BLOCKED, URIBL_DBL_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BB1441E05C for ; Fri, 13 Sep 2024 01:04:02 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 283FE385841C for ; Fri, 13 Sep 2024 05:04:02 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id AD9F93858D26 for ; Fri, 13 Sep 2024 05:03:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AD9F93858D26 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AD9F93858D26 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1726203823; cv=none; b=bxVTRXrXi03PSjw30gyj1XcFWM+mwPb/T99T5kzImRH4l8i2PBMpYHxXnzX36rYYtuhpYMmORj7M2OpAUpVN1+z1E/CMAIQIubHrEyLboFgkJ9KIxvK2zDAxgRWIp5FrOQukIEHMIcTM01Hzskh0K6jGNmBDwTn9nzZ+WdA83X0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1726203823; c=relaxed/simple; bh=8unkuTjz1/yeOyJX3SiGYrRX8pwtnFxfspOWBXSXwyQ=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=cmLlYiKikYOW6kxvttinEdZiHtg5dpC1INKO9rVRFXuEBbdOjer+dB6htWhjCcNwWIHpQdVKNQnnrLggNMG0gw6v0CXzpfNFZMaASZARU7zrNu16Nb3e78eFiXrpQlxkbeqYSTw5HRTlQiGpOPaH58Wv7w0oBhDoqmsoIwqNO08= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726203822; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LK2/mwUbmrvJIbJBG55D6e/RkD1iaM8OCM1H/8aCKyc=; b=RyxPFIJlkL274R1e6bwP/GmEoQCG7gKT0kBXbWFJyqVEBs7u3KyCW+124fPeZPYwqSWY4x At15l+Pyt0v/DG4xFCNz69G4HmT65S7cYSAAUscE7MWEINIatJQ3p/TXIon5SBkqHSZ8AU lBsynmCQ0ASj6GUSNi6gqA7A+fy15qM= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-466-LwnTwPy6NuaQc0KRTMQaDg-1; Fri, 13 Sep 2024 01:03:40 -0400 X-MC-Unique: LwnTwPy6NuaQc0KRTMQaDg-1 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BBA1419560A2; Fri, 13 Sep 2024 05:03:39 +0000 (UTC) Received: from f40-zbm-amd (unknown [10.22.65.0]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EA9AD19560AA; Fri, 13 Sep 2024 05:03:38 +0000 (UTC) Date: Thu, 12 Sep 2024 22:03:36 -0700 From: Kevin Buettner To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix quoting in gdb-add-index.sh Message-ID: <20240912220336.1a2afc89@f40-zbm-amd> In-Reply-To: <20240911143426.3040211-1-tromey@adacore.com> References: <20240911143426.3040211-1-tromey@adacore.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Wed, 11 Sep 2024 08:34:26 -0600 Tom Tromey wrote: > When the filename quoting change was merged into the AdaCore tree, we > saw a regression in a test setup that uses the DWARF 5 index (that is > running gdb-add-index), and a filename with a space in it. > > Initially I thought this was a change in the 'file' command -- but > looking again, I found out that 'file' has worked this way for a > while, and our immediate error was caused by the (documented) change > to "save gdb-index". > > While I'm not sure why this test was working previously, it seems to > me that gdb-add-index.sh requires a change to quote the arguments to > "file" and "save gdb-index". > > While working on this, though, it seemed to me that multiple other > spots needed quoting for the script to work correctly. And, I was > unable to get quoting working correctly in the objcopy calls, so I > split it into multiple different invocations. FWIW, I think it's now easier to read with separate invocations. Approved-by: Kevin Buettner