From: Kevin Buettner <kevinb@redhat.com>
To: Klaus Gerlicher <klaus.gerlicher@intel.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb, testsuite: clean duplicate header includes
Date: Thu, 12 Sep 2024 21:49:53 -0700 [thread overview]
Message-ID: <20240912214953.7bd4b3d7@f40-zbm-amd> (raw)
In-Reply-To: <20240912071728.1029978-1-klaus.gerlicher@intel.com>
On Thu, 12 Sep 2024 07:17:28 +0000
Klaus Gerlicher <klaus.gerlicher@intel.com> wrote:
> From: "Gerlicher, Klaus" <klaus.gerlicher@intel.com>
>
> Some of the gdb and testsuite files double include some headers. While
> all headers use include guards, it helps a bit keeping the code base
> tidy.
>
> No functional change.
> ---
> gdb/cli/cli-cmds.c | 1 -
> gdb/fbsd-tdep.c | 1 -
> gdb/m2-typeprint.c | 1 -
> gdb/ppc-netbsd-tdep.c | 1 -
> gdb/stack.c | 1 -
> gdb/testsuite/gdb.arch/sparc64-adi.c | 1 -
> gdb/testsuite/gdb.base/reset-catchpoint-cond-lib.c | 1 -
> gdb/testsuite/gdb.debuginfod/corefile-mapped-file-3.c | 1 -
> gdb/testsuite/gdb.multi/multi-term-settings.c | 1 -
> gdb/testsuite/gdb.server/exit-multiple-threads.c | 1 -
> gdb/testsuite/gdb.threads/create-fail.c | 2 --
> gdb/testsuite/gdb.threads/fork-thread-pending.c | 1 -
> gdb/testsuite/gdb.threads/watchpoint-fork-mt.c | 1 -
> gdb/valops.c | 1 -
> 14 files changed, 15 deletions(-)
I'm surprised at how many source file double-included headers!
Approved-by: Kevin Buettner <kevinb@redhat.com>
prev parent reply other threads:[~2024-09-13 4:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-12 7:17 Klaus Gerlicher
2024-09-13 4:49 ` Kevin Buettner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240912214953.7bd4b3d7@f40-zbm-amd \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=klaus.gerlicher@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox