From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6yMaD43E42YibikAWB0awg (envelope-from ) for ; Fri, 13 Sep 2024 00:50:21 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=UumODsOV; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 19DB91E353; Fri, 13 Sep 2024 00:50:21 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-12.8 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8AA861E05C for ; Fri, 13 Sep 2024 00:50:20 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0CE4A3858C78 for ; Fri, 13 Sep 2024 04:50:20 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 41AAD3858D28 for ; Fri, 13 Sep 2024 04:49:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 41AAD3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 41AAD3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1726203001; cv=none; b=iS4TvfvFY4dnNPmrLi1KOHQha7WPWJVFlNb+aA92PKQ/eklXpZg4kBGX11qmMxNIfW58jERaErYc7SU2VPL/B1CWIOdBJL9S3QN+DGljydh2GeoxMSuAlLqdWjZlWCKx+djeWz380QO7QvD4F3Mq9ai61z391Qi6QsFAH6gK7yM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1726203001; c=relaxed/simple; bh=NvYNuMs4CmGPNnWZ3+J5qaSdkqaqlomaomjjPtwO+Q4=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=lx/5vgTfHZggWO4x7+YH2TlqMkRX7tPqrmqPkQCN/5Nss+UGtlIVWPF7l4eTnGFiMoyVhd0FPBOxfmBWGk+Zley5YevAQNB9+IPHaNZN4fjCXxQyNoONQZU0UG6dnGdPY7Wt0wTfxdZbKGRAr5hQrBAi/mes9xdnL3ULaTQggBk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726202998; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=02vKINoKV9Hb0HIUyi/+99BayTg5199EewubIOkYY+8=; b=UumODsOVT92MDKh2SSUo7ujOKDhzkE1sieysNrYHcg3A57l8maB7ZOQeb1zHrtWde3O60V yhYfFnCA1yGK7kRKq1Jq1dxYScwi2bwRmF8UJnToR3CfumsxtRtM3X5XXlirn8Ron3fasO gyh4bEonDWPzee+lJ2VHAUR/8gDVioE= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-507-KuSW1KKvMtyCHDhnRW2nSQ-1; Fri, 13 Sep 2024 00:49:57 -0400 X-MC-Unique: KuSW1KKvMtyCHDhnRW2nSQ-1 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6D32C1955F2C; Fri, 13 Sep 2024 04:49:56 +0000 (UTC) Received: from f40-zbm-amd (unknown [10.22.65.0]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9D1A819560AA; Fri, 13 Sep 2024 04:49:55 +0000 (UTC) Date: Thu, 12 Sep 2024 21:49:53 -0700 From: Kevin Buettner To: Klaus Gerlicher Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb, testsuite: clean duplicate header includes Message-ID: <20240912214953.7bd4b3d7@f40-zbm-amd> In-Reply-To: <20240912071728.1029978-1-klaus.gerlicher@intel.com> References: <20240912071728.1029978-1-klaus.gerlicher@intel.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Thu, 12 Sep 2024 07:17:28 +0000 Klaus Gerlicher wrote: > From: "Gerlicher, Klaus" > > Some of the gdb and testsuite files double include some headers. While > all headers use include guards, it helps a bit keeping the code base > tidy. > > No functional change. > --- > gdb/cli/cli-cmds.c | 1 - > gdb/fbsd-tdep.c | 1 - > gdb/m2-typeprint.c | 1 - > gdb/ppc-netbsd-tdep.c | 1 - > gdb/stack.c | 1 - > gdb/testsuite/gdb.arch/sparc64-adi.c | 1 - > gdb/testsuite/gdb.base/reset-catchpoint-cond-lib.c | 1 - > gdb/testsuite/gdb.debuginfod/corefile-mapped-file-3.c | 1 - > gdb/testsuite/gdb.multi/multi-term-settings.c | 1 - > gdb/testsuite/gdb.server/exit-multiple-threads.c | 1 - > gdb/testsuite/gdb.threads/create-fail.c | 2 -- > gdb/testsuite/gdb.threads/fork-thread-pending.c | 1 - > gdb/testsuite/gdb.threads/watchpoint-fork-mt.c | 1 - > gdb/valops.c | 1 - > 14 files changed, 15 deletions(-) I'm surprised at how many source file double-included headers! Approved-by: Kevin Buettner