Re: [PATCH] [gdb/testsuite] Don't use set auto-solib-add off

[Kevin Buettner <kevinb@redhat.com>]

On Fri,  7 Jun 2024 16:41:35 +0200
Tom de Vries <tdevries@suse.de> wrote:

> In test-case gdb.mi/mi-var-child-f.exp, we have:
> ...
> mi_gdb_test "-gdb-set auto-solib-add off" "\\^done"
> mi_runto prog_array
> mi_gdb_test "nosharedlibrary" ".*\\^done"
> ...
> 
> This was added to avoid a name clash between the array variable as defined in
> gdb.mi/array.f90 and debug info in shared libraries, and used in other places
> in the testsuite.
> 
> The same workaround is also used to ignore symbols from shared libraries when
> excercising for instance a command that print all symbols.
> 
> However, this approach can cause problems for targets like arm that require
> symbol info for some libraries like ld.so and libc to fully function.
> 
> While absense of debug info for shared libraries should be handled gracefully
> (which does need fixing, see PR31817), failure to do so should not result
> in failures in unrelated test-cases.
> 
> Fix this by removing "set auto-solib-add off".
> 
> This ensures that we don't run into PR31817, while the presence of
> nosharedlibrary still ensures that in the rest of the test-case we're not
> bothered by shared library symbols.
> 
> Likewise in other test-cases.
> 
> Tested on arm-linux.

LGTM.

Approved-by: Kevin Buettner <kevinb@redhat.com>