From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id U++oF1dUZmaP2C0AWB0awg (envelope-from ) for ; Sun, 09 Jun 2024 21:18:15 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=iSc48HNw; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 52C401E0C1; Sun, 9 Jun 2024 21:18:15 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 34F221E092 for ; Sun, 9 Jun 2024 21:18:13 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CE3F73858D26 for ; Mon, 10 Jun 2024 01:18:12 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id AA9C23858D26 for ; Mon, 10 Jun 2024 01:17:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AA9C23858D26 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AA9C23858D26 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717982273; cv=none; b=ieKPEvPqogGm/9mWTYgPDotWAn/NoKeUihy4BtwjWu8UIsqLPrvm+Elm3bPYpdMoDpQHclJhok8aOj2gILtJPanS3pHFhmWJcyWKuNDBuOmsbndkFE7sfKcq3MgE66W5B3adDuq+CXiu8YjhMWQsMuGGgikQik0rx1b/m8u4rCc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717982273; c=relaxed/simple; bh=A2y3C+L21W/FDy19M5IWR5shWUX//Si9S5JhGryOWXk=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=NrUUQ8T1gjyPulYnTGkrdWv7nfcOvyRz03xe6CoFksZ6hHZZDahsaCjln4WcP8W/kA69MgL8f7PPtZ9UTy8J/ZyWueG/Oyj7KMidhrC59u/gITfdTHUws/Uu5nm5XZM27CSOUdIettiqUrEvkLq6+sfuB7PwsoRENToxJL/PzZk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717982272; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jRcHcQwZBltVv3D4syWsrIEtA7kKWPdSYfofvfceoTA=; b=iSc48HNwsqfklFye8eotOzbK9jqOT2GpfTaS/+qH2UJlvnLY6KpxtOhPPPnerfESOwu5be SedehP+j+QZDBCybzF9sZmKOqIYz/E8eXYeHMA0PcMKY5q5vfO1hGvjF6zgUaDcdK4lswL BN87O4LpK+6Xn7OGUu4dYgy56fMtIKU= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-568-p2KY4_kGMNaMqliGHu6_xA-1; Sun, 09 Jun 2024 21:17:50 -0400 X-MC-Unique: p2KY4_kGMNaMqliGHu6_xA-1 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CB308195608C; Mon, 10 Jun 2024 01:17:49 +0000 (UTC) Received: from f40-zbm-amd (unknown [10.22.16.37]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C4CBB1956087; Mon, 10 Jun 2024 01:17:48 +0000 (UTC) Date: Sun, 9 Jun 2024 18:17:41 -0700 From: Kevin Buettner To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] [gdb/testsuite] Don't use set auto-solib-add off Message-ID: <20240609181630.715ec02c@f40-zbm-amd> In-Reply-To: <20240607144135.32128-1-tdevries@suse.de> References: <20240607144135.32128-1-tdevries@suse.de> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, RCVD_IN_SBL_CSS, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On Fri, 7 Jun 2024 16:41:35 +0200 Tom de Vries wrote: > In test-case gdb.mi/mi-var-child-f.exp, we have: > ... > mi_gdb_test "-gdb-set auto-solib-add off" "\\^done" > mi_runto prog_array > mi_gdb_test "nosharedlibrary" ".*\\^done" > ... > > This was added to avoid a name clash between the array variable as defined in > gdb.mi/array.f90 and debug info in shared libraries, and used in other places > in the testsuite. > > The same workaround is also used to ignore symbols from shared libraries when > excercising for instance a command that print all symbols. > > However, this approach can cause problems for targets like arm that require > symbol info for some libraries like ld.so and libc to fully function. > > While absense of debug info for shared libraries should be handled gracefully > (which does need fixing, see PR31817), failure to do so should not result > in failures in unrelated test-cases. > > Fix this by removing "set auto-solib-add off". > > This ensures that we don't run into PR31817, while the presence of > nosharedlibrary still ensures that in the rest of the test-case we're not > bothered by shared library symbols. > > Likewise in other test-cases. > > Tested on arm-linux. LGTM. Approved-by: Kevin Buettner