[PATCH v2 0/3] Add amd64 LAM watchpoint support

["Schimpe, Christina" <christina.schimpe@intel.com>]

Hi all,

this is my v2 of the series "Add amd64 LAM watchpoint support".
It implements the feedback of Luis and Felix. The NEWS part has already
been approved by Eli.

Also I noticed that the gdbarch function 'gdbarch_remove_non_addr_bits_memory'
should not be used in several functions of aarch64* files (patch 1) due
to the following:

The function description for 'gdbarch_remove_non_addr_bits_memory' states:

"Given a pointer for the architecture, this hook removes all the
non-significant bits and sign-extends things as needed. It gets used to
remove non-address bits from any pointer used to access memory. "

We don't know if the pointer passed to 'gdbarch_remove_non_addr_bits_memory'
by 'gdbarch_tagged_address_p' will be used to access memory.  That's why it's
wrong to call this function in 'gdbarch_tagged_address_p'.

There are several similar wrong calls of 'gdbarch_remove_non_addr_bits_memory'
in the changes of patch 1.  I replaced all of them with
'aarch64_remove_non_address_bits'.

Changes since V1:
 * Replace gdbarch_remove_non_addr_bits_memory with
   aarch64_remove_non_address_bits in aarch64* files.
 * Improve comments and commit messages.
 * Move 'allow_lam_tests' procedure in gdb.exp to the correct location.
 * Remove abbreviations in gdbarch function names.
 * Update copyright years.

V1 of this series can be found here:
https://sourceware.org/pipermail/gdb-patches/2024-March/207589.html

I am looking forward to your feedback.

Thanks + Best Regards,
Christina


Christina Schimpe (3):
  gdb: Make tagged pointer support configurable.
  LAM: Enable tagged pointer support for watchpoints.
  LAM: Support kernel space debugging

 gdb/NEWS                             |  2 +
 gdb/aarch64-linux-nat.c              |  2 +-
 gdb/aarch64-linux-tdep.c             | 13 ++---
 gdb/aarch64-tdep.c                   | 17 ++++---
 gdb/aarch64-tdep.h                   |  6 +++
 gdb/amd64-linux-tdep.c               | 75 ++++++++++++++++++++++++++++
 gdb/breakpoint.c                     |  5 +-
 gdb/gdbarch-gen.h                    | 49 ++++++++++++++----
 gdb/gdbarch.c                        | 66 ++++++++++++++++++++----
 gdb/gdbarch_components.py            | 53 +++++++++++++++++---
 gdb/target.c                         |  3 +-
 gdb/testsuite/gdb.arch/amd64-lam.c   | 49 ++++++++++++++++++
 gdb/testsuite/gdb.arch/amd64-lam.exp | 46 +++++++++++++++++
 gdb/testsuite/lib/gdb.exp            | 63 +++++++++++++++++++++++
 14 files changed, 402 insertions(+), 47 deletions(-)
 create mode 100755 gdb/testsuite/gdb.arch/amd64-lam.c
 create mode 100644 gdb/testsuite/gdb.arch/amd64-lam.exp

-- 
2.34.1

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928