From: Kevin Buettner <kevinb@redhat.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb/symtab] Work around PR gas/29517, dwarf2 case
Date: Wed, 1 May 2024 19:07:43 -0700 [thread overview]
Message-ID: <20240501190743.4517b040@f39-zbm-amd> (raw)
In-Reply-To: <20240501144441.4921-1-tdevries@suse.de>
On Wed, 1 May 2024 16:44:41 +0200
Tom de Vries <tdevries@suse.de> wrote:
> In commit 1d45d90934b ("[gdb/symtab] Work around PR gas/29517") we added a
> workaround for PR gas/29517.
>
> The problem is present in gas version 2.39, and fixed in 2.40, so the
> workaround is only active for gas version == 2.39.
>
> However, the problem in gas is only fixed for dwarf version >= 3, which
> supports DW_TAG_unspecified_type.
>
> Fix this by also activating the workaround for dwarf version == 2.
>
> Tested on x86_64-linux.
>
> PR symtab/31689
> https://sourceware.org/bugzilla/show_bug.cgi?id=31689
LGTM.
Approved-by: Kevin Buettner <kevinb@redhat.com>
prev parent reply other threads:[~2024-05-02 2:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 14:44 Tom de Vries
2024-05-02 2:07 ` Kevin Buettner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240501190743.4517b040@f39-zbm-amd \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox