From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id U6fNIYn1MmZ8hAIAWB0awg (envelope-from ) for ; Wed, 01 May 2024 22:08:09 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=fdc8LzbF; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 6BF7D1E0C1; Wed, 1 May 2024 22:08:09 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4D6251E030 for ; Wed, 1 May 2024 22:08:07 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D5249384AB48 for ; Thu, 2 May 2024 02:08:06 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 6F2993858D34 for ; Thu, 2 May 2024 02:07:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6F2993858D34 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6F2993858D34 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714615670; cv=none; b=dTfjXmr7J3r0FQtcWthXVIU7bC3NkXm6QrkBRMpHoBW70vfHi7v24xtSx3rmx0q6OzJAeHmtrbpqcu+Os/me1ii9Pl8iIvLd9x7ah/MYoyffblBQZEJrKmaXxibMCENo+amKHA9GIIbpr81lPzeaE1/v2G/ovzrtGlhvIteKij8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714615670; c=relaxed/simple; bh=+7pEN0JNuZpewlaU6g8nC7aPILX+N/RDZp2fYAKgQf0=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=m1BXad1dyB2XLQDp3egemEVqqjfeMmX6TgHwYBnIObrs1hLLSRIa7bOGYVoiRuUZRwhuKwAbJs4I5WMQzT7zv10FtnLp4rWvj1NC9FAhvleTTHrtwfMlKGbUUQVj27vjUMBuHgW/0aR06SipsOTHtTVKE7u6DOZOKFtBDJ0TDfA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714615669; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8IcHERnM7cPcQMveB3jAaOOj0O3/oYqrc9Z8AguvBy8=; b=fdc8LzbFutE5q4QXzqtgVKwHI0idXz0aXNs3jWn+t//MaFHZ7UDb03WZc2u4B1cMOQs7Bs PKq5fEixWtJClV0d8Cr9t4f5oK2cMT+E6dKhIdiJFCiNkzU65l0mPo6qz8rIr9Wj4Lhhmp yBy33MFqzAHvQ6dmQELtRtc9VlIU1/0= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-128-2UN8ZgF3P9eIhLTNgPVPvA-1; Wed, 01 May 2024 22:07:46 -0400 X-MC-Unique: 2UN8ZgF3P9eIhLTNgPVPvA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A8F911C05AA2; Thu, 2 May 2024 02:07:45 +0000 (UTC) Received: from f39-zbm-amd (unknown [10.22.16.14]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3DE941C0666B; Thu, 2 May 2024 02:07:44 +0000 (UTC) Date: Wed, 1 May 2024 19:07:43 -0700 From: Kevin Buettner To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] [gdb/symtab] Work around PR gas/29517, dwarf2 case Message-ID: <20240501190743.4517b040@f39-zbm-amd> In-Reply-To: <20240501144441.4921-1-tdevries@suse.de> References: <20240501144441.4921-1-tdevries@suse.de> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On Wed, 1 May 2024 16:44:41 +0200 Tom de Vries wrote: > In commit 1d45d90934b ("[gdb/symtab] Work around PR gas/29517") we added a > workaround for PR gas/29517. > > The problem is present in gas version 2.39, and fixed in 2.40, so the > workaround is only active for gas version == 2.39. > > However, the problem in gas is only fixed for dwarf version >= 3, which > supports DW_TAG_unspecified_type. > > Fix this by also activating the workaround for dwarf version == 2. > > Tested on x86_64-linux. > > PR symtab/31689 > https://sourceware.org/bugzilla/show_bug.cgi?id=31689 LGTM. Approved-by: Kevin Buettner