From: Kevin Buettner <kevinb@redhat.com>
To: Pedro Alves <pedro@palves.net>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/testsuite: Fix set_unbuffered_mode.o handling in parallel mode
Date: Sat, 23 Mar 2024 13:41:26 -0700 [thread overview]
Message-ID: <20240323134126.04bd8c4c@f39-zbm-amd> (raw)
In-Reply-To: <20240322194038.1237467-1-pedro@palves.net>
On Fri, 22 Mar 2024 19:40:38 +0000
Pedro Alves <pedro@palves.net> wrote:
> Cygwin/MinGW testing links in a set_unbuffered_mode.o object to all
> test programs. When running the testsuite in parallel mode, on
> Cygwin, I noticed errors like:
>
> ERROR: remote_download to host of ..../build/set_unbuffered_mode.o to ..../build/set_unbuffered_mode_saved.o: cp: cannot open '..../build/set_unbuffered_mode.o' for reading: No such file or directory
> ...
> ERROR: remote_download to host of ..../build/set_unbuffered_mode.o to ..../build/set_unbuffered_mode_saved.o: cp: cannot stat '..../build/set_unbuffered_mode.o': No such file or directory
> ...
> ERROR: remote_download to host of ..../build/set_unbuffered_mode.o to ..../build/set_unbuffered_mode_saved.o: cp: skipping file '..../build/set_unbuffered_mode.o', as it was replaced while being copied
>
> (Absolute paths elided above.)
>
> The problem is that gdb_compile's unbuffered_mode_obj cache isn't
> parallel safe. This is fixed in this commit.
LGTM.
Reviewed-by: Kevin Buettner <kevinb@redhat.com>
next prev parent reply other threads:[~2024-03-23 20:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 19:40 Pedro Alves
2024-03-23 20:41 ` Kevin Buettner [this message]
2024-03-25 20:07 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240323134126.04bd8c4c@f39-zbm-amd \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox