From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id OU6HDZQ+/2WYWRMAWB0awg (envelope-from ) for ; Sat, 23 Mar 2024 16:41:56 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Zu0DBXM0; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 27D811E0C0; Sat, 23 Mar 2024 16:41:56 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0BDEB1E08C for ; Sat, 23 Mar 2024 16:41:54 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 899A63858C52 for ; Sat, 23 Mar 2024 20:41:53 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 7B7863858D33 for ; Sat, 23 Mar 2024 20:41:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7B7863858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7B7863858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711226497; cv=none; b=TIcrL4OaUPueWS3AIjkPQeSGXM7QBuhpg/4sjk0ivsVet3zxXp1SBv6fXgA0l7aqeb8C+uYh7AT5caCTp1nbna4CxSvGru8qkbaB9ewcYbJ8SKpnzlyG2ZmMUCE+1ygLOvf5T6FQ+Q8CJk1NQDG2o8n2ti3Id7t5bGiDltjtIFA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711226497; c=relaxed/simple; bh=26UEYxq+uP2vchCLuckpu2/mzKX66BR10ofsDXwxfGU=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=N343sKdbzQXePQ3p4am+rjrfXC6ADyFAt+U1onYClGf769vl9aFEs7hyNRopnnNWEdlk0FLo9K/nVaP3KHd+MfqfEjHv4xm8g31Kh+kCpBxs1ogqjvJ0kSVQNCDh2gVQ5TmtlXSZY6PBxzG8Uu1Caf5WN5uX7yDe2S6czqlY3Tw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711226496; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LZ4MC82p9RGAvrSgWDQ10zz8Zh70ukwsyz+GLXV+2go=; b=Zu0DBXM0cYSmYnR7bXDP02Xnhs4jcdZAgtNANU3oR8oRTZv4gfttssw1Nn8NUtfZfwsvI6 kCO7O260M+s+INQYJTRVm5cnzDi0B1fXX1GFgvOfC2Bv6mo0x3oD1hSYzR8+y0V1jKGYY5 hVGbqNlOth9boeGX8tmo1GJNyQApFWc= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-357-4PuqU8WDPrClJnZGPo3SIw-1; Sat, 23 Mar 2024 16:41:32 -0400 X-MC-Unique: 4PuqU8WDPrClJnZGPo3SIw-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 566D2380391A; Sat, 23 Mar 2024 20:41:32 +0000 (UTC) Received: from f39-zbm-amd (unknown [10.22.10.134]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 102D1492BD3; Sat, 23 Mar 2024 20:41:31 +0000 (UTC) Date: Sat, 23 Mar 2024 13:41:26 -0700 From: Kevin Buettner To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/testsuite: Fix set_unbuffered_mode.o handling in parallel mode Message-ID: <20240323134126.04bd8c4c@f39-zbm-amd> In-Reply-To: <20240322194038.1237467-1-pedro@palves.net> References: <20240322194038.1237467-1-pedro@palves.net> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On Fri, 22 Mar 2024 19:40:38 +0000 Pedro Alves wrote: > Cygwin/MinGW testing links in a set_unbuffered_mode.o object to all > test programs. When running the testsuite in parallel mode, on > Cygwin, I noticed errors like: > > ERROR: remote_download to host of ..../build/set_unbuffered_mode.o to ..../build/set_unbuffered_mode_saved.o: cp: cannot open '..../build/set_unbuffered_mode.o' for reading: No such file or directory > ... > ERROR: remote_download to host of ..../build/set_unbuffered_mode.o to ..../build/set_unbuffered_mode_saved.o: cp: cannot stat '..../build/set_unbuffered_mode.o': No such file or directory > ... > ERROR: remote_download to host of ..../build/set_unbuffered_mode.o to ..../build/set_unbuffered_mode_saved.o: cp: skipping file '..../build/set_unbuffered_mode.o', as it was replaced while being copied > > (Absolute paths elided above.) > > The problem is that gdb_compile's unbuffered_mode_obj cache isn't > parallel safe. This is fixed in this commit. LGTM. Reviewed-by: Kevin Buettner