From: Lancelot SIX <lancelot.six@amd.com>
To: Tom Tromey <tromey@adacore.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Set __file__ when source'ing a Python script
Date: Fri, 15 Mar 2024 18:56:29 +0000 [thread overview]
Message-ID: <20240315185629.a7brprfmyqviu5wk@khazad-dum> (raw)
In-Reply-To: <20240308192543.3578375-1-tromey@adacore.com>
On Fri, Mar 08, 2024 at 12:25:43PM -0700, Tom Tromey wrote:
> This patch arranges to set __file__ when source'ing a Python script.
> This fixes a problem that was introduced by the "source" rewrite, and
> then pointed out by Lancelot Six.
> ---
> gdb/python/python.c | 73 +++++++++++++++++++++++++----
> gdb/testsuite/gdb.python/source2.py | 3 ++
> 2 files changed, 66 insertions(+), 10 deletions(-)
Hi Tom,
Thanks for doing this! This does fix the regression we see. FWIW, the
patch looks reasonable to me.
Reviewed-by: Lancelot Six <lancelot.six@amd.com>
Best,
Lancelot.
next prev parent reply other threads:[~2024-03-15 18:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 19:25 Tom Tromey
2024-03-15 18:56 ` Lancelot SIX [this message]
2024-03-17 14:07 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240315185629.a7brprfmyqviu5wk@khazad-dum \
--to=lancelot.six@amd.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox