From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id VNXWLgea9GWLkwgAWB0awg (envelope-from ) for ; Fri, 15 Mar 2024 14:57:11 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=gZrl+Clo; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A112E1E0BB; Fri, 15 Mar 2024 14:57:11 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3F3C21E01D for ; Fri, 15 Mar 2024 14:57:09 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AF496385E458 for ; Fri, 15 Mar 2024 18:57:08 +0000 (GMT) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2056.outbound.protection.outlook.com [40.107.212.56]) by sourceware.org (Postfix) with ESMTPS id E2731385E445 for ; Fri, 15 Mar 2024 18:56:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E2731385E445 Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E2731385E445 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.212.56 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1710529010; cv=pass; b=x2uXZpjiAKsigYQSiGJHimduN8AHABD3SumQNUl8jo6b2hAnc6q+7sviOCI+nQ1YgefvfSabpbF72mmclFxbZ7HIVqEXH/U9lperVJOkCCEPaKI4F6PYWajcGHn/Wt/QrYCxxIgAK655YocCPDdlThCYSOGzAvpFjIu2RNWPh78= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1710529010; c=relaxed/simple; bh=O4i57mrXUoB/FiLHrW6D+VzkCXc7FG28tk/vEq6TR3g=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=p35zPdu9D33PWhPf/Sn3ZWG/ulxHmHS+7O79k98V94Nc8xjmusWMFVqJZ8gTJ/2qtRGaUi7vyHqzDJPwNe1zrwu59DeEpj8lw6YYaCOd3ux1IS+TbusZIR5MPZWytpXQzvESAiafZuo83HOw+L+yD+onHWJjmiTpMlxeWcZ5ADk= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gJrHNnHvYzW3arWfZxdqcKsWUO+ZXmwF71VF3lB+H5MUvRHD6yWtG2wpDhhl+AxBx0LqqLkTjHXO4ghSa5lXpK82/l2kvzW6qj7JcQf1WIpB4tGQyG5SEh1LEV6b7j5gb7L6a9xn/ti9/4mJ//0ehww3s15c9cUtuTpxFYZ/3EUiykvLmHTb4mCuI5kmRcKCGkkbxM6eFweUTW8nmfvMrzoqo0KBdON6miShrx1GPoKYuIvuCcB7rp4NtCsHuv7fvw7j1Cj7hsolHxDY5WU0UsZlcylPXe4QwfQFLOJ8/npKRf0HWHUhtmBHBU+o2AN7tLIYsYDas/GBXhiKB1XQGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Eft7YihHrst4Sd2pbPMZiE01ZaRo4m5ywmi7Mlotp88=; b=HOYb/jLlVQ3G7nmsN4BQHZ1uiOXsucu22grlLq0Yff4hF+uW7Wc1m9f4Kewowd428dRtvX09+vsUsOlcB3eahaBxv54rHuLTe18H9nRfFqqOs217EEOLiZaqkW8ULnnMOwyY4ZthNka2OUmIr3p6woHKhkLCkTSC1d/Tn2PGsRZoiv+GbRygaAe8KvwK8LwAZsrrjfaqZaRbNp3xNp4+TKMjaT6piqKMOouyL3UGhzMOoeszIln3KvFiebTiV3+0K3M9DJmkzgTbHIwHSLmxiO3yTVTNF4GOr3gAVHfcG/E1oCmWYAvb0mQfyL4FNI7nW6NXPVoJ2qQ0bL2ELmZrEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=adacore.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Eft7YihHrst4Sd2pbPMZiE01ZaRo4m5ywmi7Mlotp88=; b=gZrl+Clocl/gCpyPVQ98LfLYnX8uMnWaDtiLT5yaGTB9YG5nBcNBMvuPpeTZYEkfhG4vv8ImJcOmlnpSvGD0oZy+gf/dnjJiYxbTb0ERddvsMzBiE32Xk5ZoP5BWWANEy2xa395d0tGoqTAWfmZy9CL5vMLTJR5eQHorfBR8ZAw= Received: from BL0PR02CA0068.namprd02.prod.outlook.com (2603:10b6:207:3d::45) by DM4PR12MB6423.namprd12.prod.outlook.com (2603:10b6:8:bd::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.33; Fri, 15 Mar 2024 18:56:37 +0000 Received: from BL02EPF0001A0FA.namprd03.prod.outlook.com (2603:10b6:207:3d:cafe::42) by BL0PR02CA0068.outlook.office365.com (2603:10b6:207:3d::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.22 via Frontend Transport; Fri, 15 Mar 2024 18:56:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF0001A0FA.mail.protection.outlook.com (10.167.242.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7386.12 via Frontend Transport; Fri, 15 Mar 2024 18:56:37 +0000 Received: from khazad-dum (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 15 Mar 2024 13:56:36 -0500 Date: Fri, 15 Mar 2024 18:56:29 +0000 From: Lancelot SIX To: Tom Tromey CC: Subject: Re: [PATCH] Set __file__ when source'ing a Python script Message-ID: <20240315185629.a7brprfmyqviu5wk@khazad-dum> References: <20240308192543.3578375-1-tromey@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240308192543.3578375-1-tromey@adacore.com> X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A0FA:EE_|DM4PR12MB6423:EE_ X-MS-Office365-Filtering-Correlation-Id: 0bc7aeb0-2c8f-4f73-ccb4-08dc4521a491 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Xhhr0ZZC9amLokPUzpM+2YWFtT4M3+dD5svcHYhsputiYDkp7/o3BDOgrM8H/2mBOWU4/55r/O2Lp3p7sS6alkImvmETf0gsQYX2ws/afNOXPPOji9sRLq8ekFEdq+5IctqjxMjK893vX1p+IIm99tlCNm7OF8O6QzKhwLtQQdiBm8ibmoEvN3iRl2EdbEkVdpa8LQ0DOY7BP0qrPszKODiJAnfhBKG3klp3efobO7NweyUCbfxVnFd4JFodCIpwqnS1nxOzr+FxkfpI+WnnAgTgB7mC5SPvbiR990buLbZH3IYnnmgdZey/86krkTI8QoWWbFjPG8wElF2xhmbxyMQ3VbdMcBYPWkLFVX3yLmh42VhJmy4K9wtFCkXFwvX72J0VANWeNc7kMT9Y2WRgusBkQF2e5FyIgeQnJOrmHS5Wfx08wTy+9sjtK1Po84ynpqmZJN2ah8u5OtiAimPlG18YntVgn3uFVq4ZXY8o9qC8iqneOa5ln7/2KbBUqkL+dEYrx+Cpu26zl9R8668vTyRDVr6d6wPwbyygAvcskJ7FlCgryLfBn6jr3pQw/68cGVh6TZEcGM3zqOaGEElk9d4yXECKgx/ZmMYqF0ndARhkBjgpVpDP4UD5Om6nApfLJSkNJp+49C+WxQGgULrivZV5Bx4uPU8xQkFwmTkabGwxks0DHU8obmGXJc92wpmrhi3RVMYj4PI2kg2ipq/sNSia6B0NT4+23naWwWawRaYPzXfgHdVlBV0kkRVE4B0X X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(1800799015)(36860700004)(82310400014)(376005); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2024 18:56:37.6711 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0bc7aeb0-2c8f-4f73-ccb4-08dc4521a491 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A0FA.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6423 X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FORGED_SPF_HELO, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On Fri, Mar 08, 2024 at 12:25:43PM -0700, Tom Tromey wrote: > This patch arranges to set __file__ when source'ing a Python script. > This fixes a problem that was introduced by the "source" rewrite, and > then pointed out by Lancelot Six. > --- > gdb/python/python.c | 73 +++++++++++++++++++++++++---- > gdb/testsuite/gdb.python/source2.py | 3 ++ > 2 files changed, 66 insertions(+), 10 deletions(-) Hi Tom, Thanks for doing this! This does fix the regression we see. FWIW, the patch looks reasonable to me. Reviewed-by: Lancelot Six Best, Lancelot.