From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [PATCH 1/3] [gdb] Make variable printed bool in info_checkpoints_command
Date: Mon, 8 Jan 2024 16:25:51 +0100 [thread overview]
Message-ID: <20240108152553.4578-2-tdevries@suse.de> (raw)
In-Reply-To: <20240108152553.4578-1-tdevries@suse.de>
While reading info_checkpoints_command, I noticed variable printed:
...
const fork_info *printed = NULL;
...
for (const fork_info &fi : fork_list)
{
if (requested > 0 && fi.num != requested)
continue;
printed = &fi;
...
}
if (printed == NULL)
...
has pointer type, but is just used as bool.
Make this explicit by changing the variable type to bool.
Tested on x86_64-linux.
---
gdb/linux-fork.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/gdb/linux-fork.c b/gdb/linux-fork.c
index 1430ff89fa7..177a012ec08 100644
--- a/gdb/linux-fork.c
+++ b/gdb/linux-fork.c
@@ -583,7 +583,7 @@ info_checkpoints_command (const char *arg, int from_tty)
{
struct gdbarch *gdbarch = get_current_arch ();
int requested = -1;
- const fork_info *printed = NULL;
+ bool printed = false;
if (arg && *arg)
requested = (int) parse_and_eval_long (arg);
@@ -592,8 +592,8 @@ info_checkpoints_command (const char *arg, int from_tty)
{
if (requested > 0 && fi.num != requested)
continue;
+ printed = true;
- printed = &fi;
if (fi.ptid == inferior_ptid)
gdb_printf ("* ");
else
@@ -623,7 +623,8 @@ info_checkpoints_command (const char *arg, int from_tty)
gdb_putc ('\n');
}
- if (printed == NULL)
+
+ if (!printed)
{
if (requested > 0)
gdb_printf (_("No checkpoint number %d.\n"), requested);
--
2.35.3
next prev parent reply other threads:[~2024-01-08 15:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-08 15:25 [PATCH 0/3] [gdb] Two checkpoint fixes Tom de Vries
2024-01-08 15:25 ` Tom de Vries [this message]
2024-01-09 17:54 ` [PATCH 1/3] [gdb] Make variable printed bool in info_checkpoints_command Kevin Buettner
2024-01-08 15:25 ` [PATCH 2/3] [gdb] Fix info checkpoints Tom de Vries
2024-01-09 18:03 ` Kevin Buettner
2024-01-08 15:25 ` [PATCH 3/3] [gdb] Fix assertion failure for checkpoint delete 0 Tom de Vries
2024-01-10 5:28 ` Kevin Buettner
2024-01-10 10:25 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240108152553.4578-2-tdevries@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox