From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id IA6SISIUnGUczzUAWB0awg (envelope-from ) for ; Mon, 08 Jan 2024 10:26:26 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ur2B5hC4; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=vGz8CrCl; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ur2B5hC4; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=vGz8CrCl; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 85BDB1E0C3; Mon, 8 Jan 2024 10:26:26 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 651A61E0B9 for ; Mon, 8 Jan 2024 10:26:24 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E288A3860001 for ; Mon, 8 Jan 2024 15:26:23 +0000 (GMT) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 9BEA6385E00D for ; Mon, 8 Jan 2024 15:25:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9BEA6385E00D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9BEA6385E00D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704727524; cv=none; b=XvocmZu45dlQLwLSnhdnmJkUI63l2F5MNOX8Jv0UrGifr96PyhSzMm1r5A9e6R8Y5NOTHbRw2ODh/tqyWUrYgvXq0EFRtPqAk97EZOz4EsW9StddnlYUaLrfxDGVmVc40Ai09xd2XMJcTOnVtihoW/k4JdxmyDGgY+GeCqzsWko= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704727524; c=relaxed/simple; bh=Z5PsUXTJhDwQpZHyntkPgSxIBPanI0iXN3IYHv+cD+w=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-Id:MIME-Version; b=FeRG6HMmBMZByjTMI32D/H6wq2bVDD0Sn1wsK6aYxY/U1ayFBcWfj1E52U1UoW4Qhieir7E7lxUjeywQzc8VtGtxExuYL2E+gBd7NlStcDQHJNybK+29knR+AvJ5cw4lTdxbczTAaK2MWqaZZuhE1sRpS03lQUnIMI1mEPN/SNw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 956F222004 for ; Mon, 8 Jan 2024 15:25:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1704727521; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l2Z7hrrTwxN75o8ugWs825NoSv7Nq4SpuL1uk43Rk3o=; b=ur2B5hC4L3ATyZlasuJ82yHr1qv3MTF8+NK4scP0ZizZyxLWDya4ukKFchrun9KJINX4rK 4edTY7AWnSiyniy+ezFw9dA5jKDt0+ZJtpHqygxxKIlxfO3wcHe6W9HK1GHC2rc3LwOmgx EV9T7FNfWF1USvDelfFsZofCc6RkMRc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1704727521; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l2Z7hrrTwxN75o8ugWs825NoSv7Nq4SpuL1uk43Rk3o=; b=vGz8CrClbastyXwjJto3pgZbSlyIPVMwqBmKjRDICvh0AxciQCdQQ3QYitHmVRZmI/hze0 4RrVUuyd45uDEaCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1704727521; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l2Z7hrrTwxN75o8ugWs825NoSv7Nq4SpuL1uk43Rk3o=; b=ur2B5hC4L3ATyZlasuJ82yHr1qv3MTF8+NK4scP0ZizZyxLWDya4ukKFchrun9KJINX4rK 4edTY7AWnSiyniy+ezFw9dA5jKDt0+ZJtpHqygxxKIlxfO3wcHe6W9HK1GHC2rc3LwOmgx EV9T7FNfWF1USvDelfFsZofCc6RkMRc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1704727521; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l2Z7hrrTwxN75o8ugWs825NoSv7Nq4SpuL1uk43Rk3o=; b=vGz8CrClbastyXwjJto3pgZbSlyIPVMwqBmKjRDICvh0AxciQCdQQ3QYitHmVRZmI/hze0 4RrVUuyd45uDEaCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7BD8713CA7 for ; Mon, 8 Jan 2024 15:25:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 4MLgHOETnGWgUQAAD6G6ig (envelope-from ) for ; Mon, 08 Jan 2024 15:25:21 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH 1/3] [gdb] Make variable printed bool in info_checkpoints_command Date: Mon, 8 Jan 2024 16:25:51 +0100 Message-Id: <20240108152553.4578-2-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20240108152553.4578-1-tdevries@suse.de> References: <20240108152553.4578-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Authentication-Results: smtp-out1.suse.de; none X-Spam-Score: 3.69 X-Spamd-Result: default: False [3.69 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; R_MISSING_CHARSET(2.50)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; BROKEN_CONTENT_TYPE(1.50)[]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_NONE(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MID_CONTAINS_FROM(1.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-0.01)[50.66%] X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org While reading info_checkpoints_command, I noticed variable printed: ... const fork_info *printed = NULL; ... for (const fork_info &fi : fork_list) { if (requested > 0 && fi.num != requested) continue; printed = &fi; ... } if (printed == NULL) ... has pointer type, but is just used as bool. Make this explicit by changing the variable type to bool. Tested on x86_64-linux. --- gdb/linux-fork.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/gdb/linux-fork.c b/gdb/linux-fork.c index 1430ff89fa7..177a012ec08 100644 --- a/gdb/linux-fork.c +++ b/gdb/linux-fork.c @@ -583,7 +583,7 @@ info_checkpoints_command (const char *arg, int from_tty) { struct gdbarch *gdbarch = get_current_arch (); int requested = -1; - const fork_info *printed = NULL; + bool printed = false; if (arg && *arg) requested = (int) parse_and_eval_long (arg); @@ -592,8 +592,8 @@ info_checkpoints_command (const char *arg, int from_tty) { if (requested > 0 && fi.num != requested) continue; + printed = true; - printed = &fi; if (fi.ptid == inferior_ptid) gdb_printf ("* "); else @@ -623,7 +623,8 @@ info_checkpoints_command (const char *arg, int from_tty) gdb_putc ('\n'); } - if (printed == NULL) + + if (!printed) { if (requested > 0) gdb_printf (_("No checkpoint number %d.\n"), requested); -- 2.35.3