From: Kevin Buettner <kevinb@redhat.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCHv5] gdb: handle main thread exiting during detach
Date: Wed, 25 Oct 2023 14:40:30 -0700 [thread overview]
Message-ID: <20231025143943.33c91338@f38-zws-nv> (raw)
In-Reply-To: <c2cdedeb016c2c129d34e3ad6408f39664d218e3.1697622406.git.aburgess@redhat.com>
On Wed, 18 Oct 2023 10:49:44 +0100
Andrew Burgess <aburgess@redhat.com> wrote:
> gdb/linux-nat.c | 24 ++-
> gdb/remote.c | 27 +++-
> .../main-thread-exit-during-detach.c | 61 ++++++++
> .../main-thread-exit-during-detach.exp | 140 ++++++++++++++++++
> gdbserver/mem-break.cc | 11 ++
> 5 files changed, 255 insertions(+), 8 deletions(-)
> create mode 100644 gdb/testsuite/gdb.threads/main-thread-exit-during-detach.c
> create mode 100644 gdb/testsuite/gdb.threads/main-thread-exit-during-detach.exp
Thanks for the detailed commit log! It made the patch fairly easy to review.
Tested-by: Kevin Buettner <kevinb@redhat.com>
Approved-by: Kevin Buettner <kevinb@redhat.com>
next prev parent reply other threads:[~2023-10-25 21:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 14:31 [PATCH 0/2] Exit " Andrew Burgess via Gdb-patches
2023-07-18 14:31 ` [PATCH 1/2] gdb: fix possible nullptr dereference in a remote_debug_printf call Andrew Burgess via Gdb-patches
2023-07-19 15:01 ` Tom Tromey
2023-08-03 9:07 ` Andrew Burgess via Gdb-patches
2023-07-18 14:31 ` [PATCH 2/2] gdb: handle main thread exiting during detach Andrew Burgess via Gdb-patches
2023-07-18 14:40 ` Andrew Burgess via Gdb-patches
2023-08-03 9:50 ` [PATCHv2] " Andrew Burgess via Gdb-patches
2023-08-23 11:26 ` [PATCHv3] " Andrew Burgess via Gdb-patches
2023-09-29 13:57 ` [PATCHv4] " Andrew Burgess via Gdb-patches
2023-10-18 9:49 ` [PATCHv5] " Andrew Burgess
2023-10-25 21:40 ` Kevin Buettner [this message]
2023-10-26 17:26 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231025143943.33c91338@f38-zws-nv \
--to=kevinb@redhat.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox