From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id OuoeHWCLOWWS2zYAWB0awg (envelope-from ) for ; Wed, 25 Oct 2023 17:40:48 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=U5Ye0ffk; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 68E841E0C1; Wed, 25 Oct 2023 17:40:48 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4480A1E091 for ; Wed, 25 Oct 2023 17:40:46 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 851693857806 for ; Wed, 25 Oct 2023 21:40:45 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id EBA763858C31 for ; Wed, 25 Oct 2023 21:40:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EBA763858C31 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EBA763858C31 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698270035; cv=none; b=S9/7Un2G4JQOLdCcXXBwubIAR+fp2+68DyVP2qeiZIsEl28XE0DTd1VabEPnz1DzCcUf8UTETCliVFYUHnKtg5+IjzN7IMPFHufosxr5iEboTh8QQWTqZ7P/o9stXeQLknNMDJch5pDGGCTdKdZ4JL7hZyh2R9iubtn7+IAEvzw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698270035; c=relaxed/simple; bh=5YOGTD+2hqdv2ud0qVOcwMGhqL1bopdIbJLJn9l6jF8=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=ASpxohIrFGPKaLKeov/1L4LpIQ1GfQOEmLKIT57dqbP4vszSVVxWo2ZdLQqu3H8kfz8kfN13wYIicLFxGbFpkhucfNqYeXGVdNZbtmP9tCSB99t0kg/Is9QzWLTGHwxSoLi/G1s1ljxPY20zrgRe/9u5Xsk5g7TA0kGRUMe/DOY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698270033; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7Iv0DxMkizg03muu0c4+ZSnxFHgelJLw3EVME5I3dQY=; b=U5Ye0ffkXOxfqIJ1hFyf36/htor+N41itKB/8JROCtHDqBWYwGlb0PChOOzaNNNGOEb2go WO8pkU62whvVfL5fefdELESZmbkuK1H+L74MOdoILAh4v6BeJjw9jN+FemIdq//PrE8j+a OSLf/3+vizLOxQTWN1A8UI61nQQPxIE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-645-mTqoAHxTM5uY9ymE56a_xg-1; Wed, 25 Oct 2023 17:40:32 -0400 X-MC-Unique: mTqoAHxTM5uY9ymE56a_xg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EF6C9101A53B for ; Wed, 25 Oct 2023 21:40:31 +0000 (UTC) Received: from f38-zws-nv (unknown [10.22.16.59]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ACDD340C6F79; Wed, 25 Oct 2023 21:40:31 +0000 (UTC) Date: Wed, 25 Oct 2023 14:40:30 -0700 From: Kevin Buettner To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCHv5] gdb: handle main thread exiting during detach Message-ID: <20231025143943.33c91338@f38-zws-nv> In-Reply-To: References: <996bb6a9da928e3512ea8ac7e92e80f78ada0fe1.1695995773.git.aburgess@redhat.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On Wed, 18 Oct 2023 10:49:44 +0100 Andrew Burgess wrote: > gdb/linux-nat.c | 24 ++- > gdb/remote.c | 27 +++- > .../main-thread-exit-during-detach.c | 61 ++++++++ > .../main-thread-exit-during-detach.exp | 140 ++++++++++++++++++ > gdbserver/mem-break.cc | 11 ++ > 5 files changed, 255 insertions(+), 8 deletions(-) > create mode 100644 gdb/testsuite/gdb.threads/main-thread-exit-during-detach.c > create mode 100644 gdb/testsuite/gdb.threads/main-thread-exit-during-detach.exp Thanks for the detailed commit log! It made the patch fairly easy to review. Tested-by: Kevin Buettner Approved-by: Kevin Buettner