Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Kevin Buettner via Gdb-patches <gdb-patches@sourceware.org>
To: Lancelot SIX <lsix@lancelotsix.com>
Cc: gdb-patches@sourceware.org, Jan Kratochvil <jan@jankratochvil.net>
Subject: Re: [PATCH v2] gdb/testsuite: Add relative versus absolute LD_LIBRARY_PATH test
Date: Thu, 28 Sep 2023 18:52:37 -0700	[thread overview]
Message-ID: <20230928185237.379c781c@f37-zws-nv> (raw)
In-Reply-To: <20230928110545.fwldrllu4cg6n3rf@octopus>

On Thu, 28 Sep 2023 12:05:45 +0100
Lancelot SIX <lsix@lancelotsix.com> wrote:

> FWIW, the patch looks good to me.  I do have one extra small detail
> inlined below.
> 
> With that small fix (tested locally),
> Reviewed-By: Lancelot Six <lancelot.six@amd.com>
[...]
> I think here you can be more specific as you know the actual value which
> is expected:
> 
>                  "\\\$1 = 42"

I've made this change, added your Reviewed-by, and pushed this commit.

Thanks for your reviews!

Kevin


      reply	other threads:[~2023-09-29  1:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-26  0:07 Kevin Buettner via Gdb-patches
2023-09-28 11:05 ` Lancelot SIX via Gdb-patches
2023-09-29  1:52   ` Kevin Buettner via Gdb-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230928185237.379c781c@f37-zws-nv \
    --to=gdb-patches@sourceware.org \
    --cc=jan@jankratochvil.net \
    --cc=kevinb@redhat.com \
    --cc=lsix@lancelotsix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox