From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id pD42CgYuFmXUwh8AWB0awg (envelope-from ) for ; Thu, 28 Sep 2023 21:53:10 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=s8c3wGV3; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 20EBE1E0C3; Thu, 28 Sep 2023 21:53:10 -0400 (EDT) Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 14D1A1E028 for ; Thu, 28 Sep 2023 21:53:08 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7EC19385C6FE for ; Fri, 29 Sep 2023 01:53:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7EC19385C6FE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1695952387; bh=cPKhfpxOkmF8nX6MIbt/hYs3ldFNTTesrXh25wIaZ+M=; h=Date:To:Cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=s8c3wGV3PpTZGY01LlLb6bSHR0cNeU1Erh2X7tCeOh/POHpL0lIvcX+Uqs2ZRkZ5r WfpRJcHA3nQFhVRyC3uyWLR/Mj+nbBQnPPYydWPktbjWFxQM4IMouovv/jGC7aEIgp zhZZEIww8FotqH+mClSKOAnVKImmAAvS3YVVBySw= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id D96493858C52 for ; Fri, 29 Sep 2023 01:52:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D96493858C52 Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-57-3uT2V8OeOriKLitg7ioZfg-1; Thu, 28 Sep 2023 21:52:40 -0400 X-MC-Unique: 3uT2V8OeOriKLitg7ioZfg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D2DB63C0DF90; Fri, 29 Sep 2023 01:52:39 +0000 (UTC) Received: from f37-zws-nv (unknown [10.22.32.95]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 62F4B40C6E76; Fri, 29 Sep 2023 01:52:39 +0000 (UTC) Date: Thu, 28 Sep 2023 18:52:37 -0700 To: Lancelot SIX Cc: gdb-patches@sourceware.org, Jan Kratochvil Subject: Re: [PATCH v2] gdb/testsuite: Add relative versus absolute LD_LIBRARY_PATH test Message-ID: <20230928185237.379c781c@f37-zws-nv> In-Reply-To: <20230928110545.fwldrllu4cg6n3rf@octopus> References: <20230926000918.3270325-1-kevinb@redhat.com> <20230928110545.fwldrllu4cg6n3rf@octopus> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, RCVD_IN_SBL_CSS, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kevin Buettner via Gdb-patches Reply-To: Kevin Buettner Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Thu, 28 Sep 2023 12:05:45 +0100 Lancelot SIX wrote: > FWIW, the patch looks good to me. I do have one extra small detail > inlined below. > > With that small fix (tested locally), > Reviewed-By: Lancelot Six [...] > I think here you can be more specific as you know the actual value which > is expected: > > "\\\$1 = 42" I've made this change, added your Reviewed-by, and pushed this commit. Thanks for your reviews! Kevin