Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Kevin Buettner via Gdb-patches <gdb-patches@sourceware.org>
To: gdb-patches@sourceware.org
Subject: [PATCH v4 0/2] [symtab/27831] Fix OBJF_MAINLINE assert
Date: Mon, 28 Aug 2023 18:57:50 -0700	[thread overview]
Message-ID: <20230829021017.1701373-1-kevinb@redhat.com> (raw)

This v4 series addresses a concern that Tom had regarding incorrect
evaluation (of globals) for non-ELF object file formats.

Also, during testing, I found that the new test was racy, so I fixed
that problem in addition to making minor modernizations to the test
case.

Tested on Fedora 38 for both x86_64 and aarch64 with no regressions
found.  Also, the new test shows one failure without the fix and no
failures with the fix.

Kevin Buettner (2):
  [symtab/27831] Fix OBJF_MAINLINE assert
  [symtab/27831] New test case: gdb.base/add-symbol-file-attach.exp

 gdb/elfread.c                                 | 12 ++-
 gdb/objfiles.h                                | 11 +++
 gdb/symtab.c                                  | 14 +++-
 gdb/symtab.h                                  | 17 ++--
 .../gdb.base/add-symbol-file-attach.c         | 28 +++++++
 .../gdb.base/add-symbol-file-attach.exp       | 82 +++++++++++++++++++
 6 files changed, 147 insertions(+), 17 deletions(-)
 create mode 100644 gdb/testsuite/gdb.base/add-symbol-file-attach.c
 create mode 100644 gdb/testsuite/gdb.base/add-symbol-file-attach.exp

-- 
2.41.0


             reply	other threads:[~2023-08-29  2:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-29  1:57 Kevin Buettner via Gdb-patches [this message]
2023-08-29  1:57 ` [PATCH v4 1/2] " Kevin Buettner via Gdb-patches
2023-08-29  1:57 ` [PATCH v4 2/2] [symtab/27831] New test case: gdb.base/add-symbol-file-attach.exp Kevin Buettner via Gdb-patches
2023-08-31 13:24 ` [PATCH v4 0/2] [symtab/27831] Fix OBJF_MAINLINE assert Tom Tromey
2023-08-31 14:57   ` Kevin Buettner via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230829021017.1701373-1-kevinb@redhat.com \
    --to=gdb-patches@sourceware.org \
    --cc=kevinb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox