From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cPSaN81T7WRZFg0AWB0awg (envelope-from ) for ; Mon, 28 Aug 2023 22:11:25 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=qqR9RwU7; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id DB9D91E0C2; Mon, 28 Aug 2023 22:11:25 -0400 (EDT) Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CB08A1E028 for ; Mon, 28 Aug 2023 22:11:23 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 78537385840C for ; Tue, 29 Aug 2023 02:11:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 78537385840C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1693275083; bh=SaUrSBbR6CqcF8V2R0Vq8vGtj4GACwgFMxrfZ/qMO7E=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=qqR9RwU76scNTTbClNlI5Lv3yPVH3vBAc5m/CRbcygqjSAJPdlvF874GXJa/FGBb8 GforLh5Ue0sCvTZReUnWBVvDE5pVDJcMlBy4l/e6/44LTKJGkaEmp6xBGnICQglb89 busxFtAgpfBmFLJn8mUsXtXHY6qCYwqK49MGAybs= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 6AEC53858C54 for ; Tue, 29 Aug 2023 02:10:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6AEC53858C54 Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-46-OJ2lv9QRNb6oyxEIRenllw-1; Mon, 28 Aug 2023 22:10:44 -0400 X-MC-Unique: OJ2lv9QRNb6oyxEIRenllw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 56197299E74F for ; Tue, 29 Aug 2023 02:10:44 +0000 (UTC) Received: from f38-1.lan (unknown [10.22.16.35]) by smtp.corp.redhat.com (Postfix) with ESMTP id F2BF6C15E6A; Tue, 29 Aug 2023 02:10:43 +0000 (UTC) To: gdb-patches@sourceware.org Subject: [PATCH v4 0/2] [symtab/27831] Fix OBJF_MAINLINE assert Date: Mon, 28 Aug 2023 18:57:50 -0700 Message-ID: <20230829021017.1701373-1-kevinb@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kevin Buettner via Gdb-patches Reply-To: Kevin Buettner Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" This v4 series addresses a concern that Tom had regarding incorrect evaluation (of globals) for non-ELF object file formats. Also, during testing, I found that the new test was racy, so I fixed that problem in addition to making minor modernizations to the test case. Tested on Fedora 38 for both x86_64 and aarch64 with no regressions found. Also, the new test shows one failure without the fix and no failures with the fix. Kevin Buettner (2): [symtab/27831] Fix OBJF_MAINLINE assert [symtab/27831] New test case: gdb.base/add-symbol-file-attach.exp gdb/elfread.c | 12 ++- gdb/objfiles.h | 11 +++ gdb/symtab.c | 14 +++- gdb/symtab.h | 17 ++-- .../gdb.base/add-symbol-file-attach.c | 28 +++++++ .../gdb.base/add-symbol-file-attach.exp | 82 +++++++++++++++++++ 6 files changed, 147 insertions(+), 17 deletions(-) create mode 100644 gdb/testsuite/gdb.base/add-symbol-file-attach.c create mode 100644 gdb/testsuite/gdb.base/add-symbol-file-attach.exp -- 2.41.0