From: Kevin Buettner via Gdb-patches <gdb-patches@sourceware.org>
To: gdb-patches@sourceware.org
Cc: Lancelot SIX <lsix@lancelotsix.com>
Subject: Re: [PATCH 2/2] BFD error message suppression test case
Date: Tue, 6 Sep 2022 16:21:33 -0700 [thread overview]
Message-ID: <20220906162133.0e2460b5@f35-zws-1> (raw)
In-Reply-To: <20220906102908.qrvisybbnyg4idhp@ubuntu.lan>
On Tue, 6 Sep 2022 10:29:08 +0000
Lancelot SIX <lsix@lancelotsix.com> wrote:
> When applying this patch, I have:
>
> Applying: BFD error message suppression test case
> [...]/rebase-apply/patch:269: trailing whitespace.
> # in the dynamic linker/loader due to using a mangled shared object.
> warning: 1 line adds whitespace errors.
Thanks. I've fixed this in my local sources.
> Also, on my systems (ubuntu 22.04 and ubuntu 20.04), the test fails:
>
> (gdb) catch load bfd-errors-lib
> Catchpoint 1 (load)
> (gdb) PASS: gdb.base/bfd-errors.exp: catch load bfd-errors-lib
> run
> Starting program: .../gdb/testsuite/outputs/gdb.base/bfd-errors/bfd-errors-main
> .../gdb/testsuite/outputs/gdb.base/bfd-errors/bfd-errors-main: symbol lookup error: .../gdb/testsuite/outputs/gdb.base/bfd-errors/bfd-errors-main: undefined symbol: foo4
> [Inferior 1 (process 19165) exited with code 0177]
> (gdb) FAIL: gdb.base/bfd-errors.exp: run to catchpoint (the program exited)
> PASS: gdb.base/bfd-errors.exp: consolidated bfd errors
> FAIL: gdb.base/bfd-errors.exp: print all unique bfd error
I've reproduced this on Ubuntu 22.04.
I was concerned that setting a catchpoint on the shared library load
might be fragile. Sadly, it seems that it is. I was expecting it to break
differently than what we're seeing on Ubuntu though.
I've perhaps come up with a different approach using 'add-symbol-file'
which I'll (try to) put into a v2 series. If it works, this will take
the dynamic linker entirely out of the picture and also won't rely on
a load actually being caught.
> I also have minor comments inlined in the patch.
Thanks - I'll make those adjustments in the v2 series too.
Kevin
P.S. Thanks, too, for your comments on part 1 of this series.
prev parent reply other threads:[~2022-09-06 23:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-03 0:47 [PATCH 0/2] Suppress printing of superfluous BFD error messages Kevin Buettner via Gdb-patches
2022-09-03 0:47 ` [PATCH 1/2] " Kevin Buettner via Gdb-patches
2022-09-06 10:09 ` Lancelot SIX via Gdb-patches
2022-09-03 0:47 ` [PATCH 2/2] BFD error message suppression test case Kevin Buettner via Gdb-patches
2022-09-06 10:29 ` Lancelot SIX via Gdb-patches
2022-09-06 23:21 ` Kevin Buettner via Gdb-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220906162133.0e2460b5@f35-zws-1 \
--to=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
--cc=lsix@lancelotsix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox