From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SyVqBBzWF2MrwzQAWB0awg (envelope-from ) for ; Tue, 06 Sep 2022 19:22:04 -0400 Received: by simark.ca (Postfix, from userid 112) id 00E851E4A7; Tue, 6 Sep 2022 19:22:03 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=NFPYfktM; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0BE761E21F for ; Tue, 6 Sep 2022 19:22:00 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6BE25385084C for ; Tue, 6 Sep 2022 23:21:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6BE25385084C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1662506519; bh=BJbx/T4/NEJ77TfQr1w2bJE+vQxbAvnbr1JqlALunSU=; h=Date:To:Subject:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=NFPYfktMoSVW/QVcToZn3d0jvdVwxpwTamTsHFNhguRpFRwuuvMtFW/WLMzxV+5BI 8wCWmv5M9vHfFXc5OvhSC8cTaD2J3bR95QVBbQRNEaZtuZBctIA9E9w50IPj9WydYP NlLlQ75F4Iat6+nENyElGqJEPPYo+b321MDvazfo= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 991BA3858297 for ; Tue, 6 Sep 2022 23:21:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 991BA3858297 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-539-w13hpf9wOR22k7KBw8VbYw-1; Tue, 06 Sep 2022 19:21:36 -0400 X-MC-Unique: w13hpf9wOR22k7KBw8VbYw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9FBFC3804073; Tue, 6 Sep 2022 23:21:35 +0000 (UTC) Received: from f35-zws-1 (unknown [10.2.16.60]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5B465492C3B; Tue, 6 Sep 2022 23:21:35 +0000 (UTC) Date: Tue, 6 Sep 2022 16:21:33 -0700 To: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] BFD error message suppression test case Message-ID: <20220906162133.0e2460b5@f35-zws-1> In-Reply-To: <20220906102908.qrvisybbnyg4idhp@ubuntu.lan> References: <20220903004759.2082950-1-kevinb@redhat.com> <20220903004759.2082950-3-kevinb@redhat.com> <20220906102908.qrvisybbnyg4idhp@ubuntu.lan> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kevin Buettner via Gdb-patches Reply-To: Kevin Buettner Cc: Lancelot SIX Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Tue, 6 Sep 2022 10:29:08 +0000 Lancelot SIX wrote: > When applying this patch, I have: > > Applying: BFD error message suppression test case > [...]/rebase-apply/patch:269: trailing whitespace. > # in the dynamic linker/loader due to using a mangled shared object. > warning: 1 line adds whitespace errors. Thanks. I've fixed this in my local sources. > Also, on my systems (ubuntu 22.04 and ubuntu 20.04), the test fails: > > (gdb) catch load bfd-errors-lib > Catchpoint 1 (load) > (gdb) PASS: gdb.base/bfd-errors.exp: catch load bfd-errors-lib > run > Starting program: .../gdb/testsuite/outputs/gdb.base/bfd-errors/bfd-errors-main > .../gdb/testsuite/outputs/gdb.base/bfd-errors/bfd-errors-main: symbol lookup error: .../gdb/testsuite/outputs/gdb.base/bfd-errors/bfd-errors-main: undefined symbol: foo4 > [Inferior 1 (process 19165) exited with code 0177] > (gdb) FAIL: gdb.base/bfd-errors.exp: run to catchpoint (the program exited) > PASS: gdb.base/bfd-errors.exp: consolidated bfd errors > FAIL: gdb.base/bfd-errors.exp: print all unique bfd error I've reproduced this on Ubuntu 22.04. I was concerned that setting a catchpoint on the shared library load might be fragile. Sadly, it seems that it is. I was expecting it to break differently than what we're seeing on Ubuntu though. I've perhaps come up with a different approach using 'add-symbol-file' which I'll (try to) put into a v2 series. If it works, this will take the dynamic linker entirely out of the picture and also won't rely on a load actually being caught. > I also have minor comments inlined in the patch. Thanks - I'll make those adjustments in the v2 series too. Kevin P.S. Thanks, too, for your comments on part 1 of this series.