Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
To: Tsukasa OI <research_trasio@irq.a4lg.com>
Cc: Nelson Chu <nelson@rivosinc.com>,
	Kito Cheng <kito.cheng@sifive.com>,
	gdb-patches@sourceware.org
Subject: Re: [PATCH 1/1] sim/riscv: Complete tidying up with SBREAK
Date: Sun, 4 Sep 2022 18:07:26 +0100	[thread overview]
Message-ID: <20220904170726.GB745711@redhat.com> (raw)
In-Reply-To: <9397aa661e0b6ba2c02c96f166088387a99c84a8.1662277499.git.research_trasio@irq.a4lg.com>

* Tsukasa OI <research_trasio@irq.a4lg.com> [2022-09-04 07:45:06 +0000]:

> This commit removes SBREAK-related references on the simulator as it's
> renamed to EBREAK in 2016 (the RISC-V ISA, version 2.1).
> 
> sim/ChangeLog:
> 
> 	* riscv/sim-main.c (execute_i): Use "ebreak" instead of "sbreak".

Approved.  Please go ahead and apply.

Thanks,
Andrew


> ---
>  sim/riscv/sim-main.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/sim/riscv/sim-main.c b/sim/riscv/sim-main.c
> index 62f475671c9..30d2f1e1c9a 100644
> --- a/sim/riscv/sim-main.c
> +++ b/sim/riscv/sim-main.c
> @@ -583,9 +583,9 @@ execute_i (SIM_CPU *cpu, unsigned_word iw, const struct riscv_opcode *op)
>      case MATCH_FENCE_I:
>        TRACE_INSN (cpu, "fence.i;");
>        break;
> -    case MATCH_SBREAK:
> -      TRACE_INSN (cpu, "sbreak;");
> -      /* GDB expects us to step over SBREAK.  */
> +    case MATCH_EBREAK:
> +      TRACE_INSN (cpu, "ebreak;");
> +      /* GDB expects us to step over EBREAK.  */
>        sim_engine_halt (sd, cpu, NULL, cpu->pc + 4, sim_stopped, SIM_SIGTRAP);
>        break;
>      case MATCH_ECALL:
> -- 
> 2.34.1
> 


  reply	other threads:[~2022-09-04 17:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-04  7:45 [PATCH 0/1] " Tsukasa OI via Gdb-patches
2022-09-04  7:45 ` [PATCH 1/1] " Tsukasa OI via Gdb-patches
2022-09-04 17:07   ` Andrew Burgess via Gdb-patches [this message]
2022-09-05  8:45     ` Andrew Burgess via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220904170726.GB745711@redhat.com \
    --to=gdb-patches@sourceware.org \
    --cc=aburgess@redhat.com \
    --cc=kito.cheng@sifive.com \
    --cc=nelson@rivosinc.com \
    --cc=research_trasio@irq.a4lg.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox