From: Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org>
To: gdb-patches@sourceware.org
Cc: pedro@palves.net
Subject: [PATCH v2 0/2] Fix reverse nexting over recursions
Date: Tue, 23 Aug 2022 16:22:03 +0200 [thread overview]
Message-ID: <20220823142204.31659-1-blarsen@redhat.com> (raw)
This patch series fixes gdb record/16678, GDB being unable to
reverse-next over a recursive function. However, the simple way to fix
it hit a snag when I discovered that the amd64 epilogue unwinder would
give a different frame id than the dwarf2 unwinder would in the rest of
the function. This patch series first change this discrepancy, then
fixes the bug.
Changelog for v2:
* Implemented Pedro Alves's suggestion to simplify the fix
* Added the first patch to fix a regression that the simple fix
would introduce.
Bruno Larsen (2):
Change calculation of frame_id by amd64 epilogue unwinder
gdb/reverse: Fix stepping over recursive functions
gdb/amd64-tdep.c | 4 +-
gdb/infrun.c | 2 +-
gdb/testsuite/gdb.reverse/step-precsave.exp | 6 ++-
gdb/testsuite/gdb.reverse/step-reverse.c | 16 +++++-
gdb/testsuite/gdb.reverse/step-reverse.exp | 59 +++++++++++++++++++--
5 files changed, 78 insertions(+), 9 deletions(-)
--
2.37.2
next reply other threads:[~2022-08-23 14:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 14:22 Bruno Larsen via Gdb-patches [this message]
2022-08-23 14:22 ` [PATCH v2 1/2] Change calculation of frame_id by amd64 epilogue unwinder Bruno Larsen via Gdb-patches
2022-08-24 13:11 ` Andrew Burgess via Gdb-patches
2022-08-24 13:42 ` Andrew Burgess via Gdb-patches
2022-08-30 11:35 ` Bruno Larsen via Gdb-patches
2022-08-24 15:38 ` Andrew Burgess via Gdb-patches
2022-08-23 14:22 ` [PATCH v2 2/2] gdb/reverse: Fix stepping over recursive functions Bruno Larsen via Gdb-patches
2022-08-24 13:40 ` Andrew Burgess via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220823142204.31659-1-blarsen@redhat.com \
--to=gdb-patches@sourceware.org \
--cc=blarsen@redhat.com \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox