From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id pCxVNKflBGPmDywAWB0awg (envelope-from ) for ; Tue, 23 Aug 2022 10:35:19 -0400 Received: by simark.ca (Postfix, from userid 112) id C897E1E4A7; Tue, 23 Aug 2022 10:35:19 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=DlgDXXOS; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 562E31E13B for ; Tue, 23 Aug 2022 10:35:18 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 407903858289 for ; Tue, 23 Aug 2022 14:35:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 407903858289 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1661265315; bh=DqFRkWaGJyPr29CtMykyJ+uM/mCkd1pBLE1OuHEW83Q=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=DlgDXXOSBaeDgweX37SyzHPbuT4YOxiI6CW5CjrHvQj0fzT7bLXTduSHSNzO2x9lR 0ETm1P7zm1c0ziEZ5ddeAQlQvKdKrLuKtLk4fTwjXn/PDODyzPcTPghhdnanO7vVzs cylKLppdBHoMSZ6pMfuvGjcPiBS5bJgYtIHjsI3w= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 559ED3858282 for ; Tue, 23 Aug 2022 14:34:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 559ED3858282 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-584-0mpQg0RJOR6B5meaf7KaQw-1; Tue, 23 Aug 2022 10:34:52 -0400 X-MC-Unique: 0mpQg0RJOR6B5meaf7KaQw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 66C1285A589; Tue, 23 Aug 2022 14:34:52 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.40.194.157]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5DCD61121314; Tue, 23 Aug 2022 14:34:51 +0000 (UTC) To: gdb-patches@sourceware.org Subject: [PATCH v2 0/2] Fix reverse nexting over recursions Date: Tue, 23 Aug 2022 16:22:03 +0200 Message-Id: <20220823142204.31659-1-blarsen@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Bruno Larsen via Gdb-patches Reply-To: Bruno Larsen Cc: pedro@palves.net Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" This patch series fixes gdb record/16678, GDB being unable to reverse-next over a recursive function. However, the simple way to fix it hit a snag when I discovered that the amd64 epilogue unwinder would give a different frame id than the dwarf2 unwinder would in the rest of the function. This patch series first change this discrepancy, then fixes the bug. Changelog for v2: * Implemented Pedro Alves's suggestion to simplify the fix * Added the first patch to fix a regression that the simple fix would introduce. Bruno Larsen (2): Change calculation of frame_id by amd64 epilogue unwinder gdb/reverse: Fix stepping over recursive functions gdb/amd64-tdep.c | 4 +- gdb/infrun.c | 2 +- gdb/testsuite/gdb.reverse/step-precsave.exp | 6 ++- gdb/testsuite/gdb.reverse/step-reverse.c | 16 +++++- gdb/testsuite/gdb.reverse/step-reverse.exp | 59 +++++++++++++++++++-- 5 files changed, 78 insertions(+), 9 deletions(-) -- 2.37.2