[PATCH v2 0/2] Handle undnamed template tags in GDB

[PATCH v2 0/2] Handle undnamed template tags in GDB

[Nils-Christian Kempke via Gdb-patches]

Hi,

please find attached version 2 of this series, originally posted here:

https://sourceware.org/pipermail/gdb-patches/2022-July/190574.html

Changes since version 1 are mostly incorporating Bruno's comments:

Patch 1:
  * This is new and fixes a problem with the testsuite that I
  stumbled upon while reworking patch 2.
  
Patch 2:
  * Patch 2 now adds a .cc file with the testcase that should make
  the test and the DWARF written in the test clearer.  The .cc and its
  DWARF are very close to what clang (10) emits for this example.
  * I fixed Patch 2's commit message.
  * I reordered some of the variables in Patch 2 (to be closer to what
  clang emits for the .cc file.
  * I changed the type of the second template value parameter from float
  to int (as float is an illegal type for a template value parameter).

What I could not reproduce was the failure Bruno described in his
first review:

I ran 

  make check TESTS="gdb.dwarf2/missing-type-name-for-templates.exp"

(also with boards unix/-m32, native-gdbserver,
native-extended-gdbserver) on Ubuntu 20 with gcc 13 and on RHL 10.3.1-1
with gcc 10.3.1 and could not see any failures with my original version
of the patch.

@Bruno Could you try this again?  I'm quite unsure how to reproduce
these but I noted that the second template value parameter was declared
to be of type float - which is illegal and might have caused this.  I
changed its type to int and both template value parameters are
now declared the same way.  It would be surprising to me if this still
failed.

I tested v2 against regressions on the Ubuntu 20 system and all boards
described but could not find any.

Cheers,
Nils

Nils-Christian Kempke (2):
  gdb, testsuite: adapt function_range expected name
  gdb, dwarf: create symbols for template tags without names

 gdb/dwarf2/read.c                             |  46 ++++-
 .../missing-type-name-for-templates.cc        |  58 ++++++
 .../missing-type-name-for-templates.exp       | 170 ++++++++++++++++++
 gdb/testsuite/lib/dwarf.exp                   |  12 +-
 4 files changed, 281 insertions(+), 5 deletions(-)
 create mode 100644 gdb/testsuite/gdb.dwarf2/missing-type-name-for-templates.cc
 create mode 100644 gdb/testsuite/gdb.dwarf2/missing-type-name-for-templates.exp

-- 
2.25.1

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928