From: Kevin Buettner via Gdb-patches <gdb-patches@sourceware.org>
To: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tromey@adacore.com>
Subject: Re: [PATCH] Constify solib_name_from_address
Date: Mon, 6 Jun 2022 17:04:22 -0700 [thread overview]
Message-ID: <20220606170422.1ea32f74@f35-zws-1> (raw)
In-Reply-To: <20220606155712.2039476-1-tromey@adacore.com>
On Mon, 6 Jun 2022 09:57:12 -0600
Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> wrote:
> I noticed that solib_name_from_address returned a non-const string,
> but it's more appropriate to return const. This patch implements
> this. Tested by rebuilding.
> ---
> gdb/python/py-progspace.c | 3 +--
> gdb/solib.c | 2 +-
> gdb/solib.h | 2 +-
> gdb/stack.c | 5 +++--
LGTM.
Kevin
prev parent reply other threads:[~2022-06-07 0:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 15:57 Tom Tromey via Gdb-patches
2022-06-07 0:04 ` Kevin Buettner via Gdb-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220606170422.1ea32f74@f35-zws-1 \
--to=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox