From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cGAbBCCWnmLNFQsAWB0awg (envelope-from ) for ; Mon, 06 Jun 2022 20:04:48 -0400 Received: by simark.ca (Postfix, from userid 112) id ED0461E222; Mon, 6 Jun 2022 20:04:47 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=ZSX4aCtG; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6E8051E00D for ; Mon, 6 Jun 2022 20:04:47 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A50C938303FC for ; Tue, 7 Jun 2022 00:04:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A50C938303FC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1654560286; bh=trP9l0GXjLorSFAOJaRUsNoUjmn5gPBhtoSI54BLjGg=; h=Date:To:Subject:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ZSX4aCtGvWS9LDOMU6iistdVa/fFeg7UPpko5H3tAPhjWdeoMRS7W+U7F0uq81Bag KhVTPi4TwzTaw0/gRurf+5Zsj1Nnm3XrIM9QJrroRw7s82/XwrE5paiAHn91wyWLDb bsUOhblSuV8y6SAauRSSecUXno0WMQU5/SZ/LPuU= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id A33213850860 for ; Tue, 7 Jun 2022 00:04:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A33213850860 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-413-watM1uYbME-0div9MoiyBA-1; Mon, 06 Jun 2022 20:04:25 -0400 X-MC-Unique: watM1uYbME-0div9MoiyBA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0FD381C05EA9; Tue, 7 Jun 2022 00:04:25 +0000 (UTC) Received: from f35-zws-1 (unknown [10.2.17.206]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 983541400E73; Tue, 7 Jun 2022 00:04:24 +0000 (UTC) Date: Mon, 6 Jun 2022 17:04:22 -0700 To: Tom Tromey via Gdb-patches Subject: Re: [PATCH] Constify solib_name_from_address Message-ID: <20220606170422.1ea32f74@f35-zws-1> In-Reply-To: <20220606155712.2039476-1-tromey@adacore.com> References: <20220606155712.2039476-1-tromey@adacore.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kevin Buettner via Gdb-patches Reply-To: Kevin Buettner Cc: Tom Tromey Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Mon, 6 Jun 2022 09:57:12 -0600 Tom Tromey via Gdb-patches wrote: > I noticed that solib_name_from_address returned a non-const string, > but it's more appropriate to return const. This patch implements > this. Tested by rebuilding. > --- > gdb/python/py-progspace.c | 3 +-- > gdb/solib.c | 2 +- > gdb/solib.h | 2 +- > gdb/stack.c | 5 +++-- LGTM. Kevin