Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [PATCH/committed] sim: testsuite: cleanup the istarget * logic
@ 2022-02-16  5:44 Mike Frysinger via Gdb-patches
  0 siblings, 0 replies; only message in thread
From: Mike Frysinger via Gdb-patches @ 2022-02-16  5:44 UTC (permalink / raw)
  To: gdb-patches

Now that the multitarget testing has settled, clean up the cases where
istarget * is used.  This ends up being mostly style unindenting.
---
 sim/testsuite/aarch64/allinsn.exp         | 17 ++++----
 sim/testsuite/arm/allinsn.exp             | 22 +++++------
 sim/testsuite/arm/iwmmxt/iwmmxt.exp       | 22 +++++------
 sim/testsuite/arm/misc.exp                | 22 +++++------
 sim/testsuite/arm/thumb/allthumb.exp      | 22 +++++------
 sim/testsuite/arm/xscale/xscale.exp       | 22 +++++------
 sim/testsuite/avr/allinsn.exp             | 17 ++++----
 sim/testsuite/bfin/allinsn.exp            | 17 ++++----
 sim/testsuite/bpf/allinsn.exp             | 26 ++++++------
 sim/testsuite/cr16/allinsn.exp            | 28 ++++++-------
 sim/testsuite/cr16/misc.exp               | 28 ++++++-------
 sim/testsuite/cris/asm/asm.exp            | 48 +++++++++++------------
 sim/testsuite/d10v/allinsn.exp            | 17 ++++----
 sim/testsuite/example-synacor/allinsn.exp | 21 +++++-----
 sim/testsuite/frv/allinsn-a-b.exp         |  3 +-
 sim/testsuite/frv/allinsn-c.exp           |  3 +-
 sim/testsuite/frv/allinsn-d-h.exp         |  3 +-
 sim/testsuite/frv/allinsn-i-l.exp         |  3 +-
 sim/testsuite/frv/allinsn-m.exp           |  3 +-
 sim/testsuite/frv/allinsn-n.exp           |  3 +-
 sim/testsuite/frv/allinsn-o-s.exp         |  3 +-
 sim/testsuite/frv/allinsn-t-z.exp         |  3 +-
 sim/testsuite/frv/fr400/allinsn.exp       | 21 +++++-----
 sim/testsuite/frv/fr500/allinsn.exp       | 21 +++++-----
 sim/testsuite/frv/fr550/allinsn.exp       | 21 +++++-----
 sim/testsuite/frv/interrupts.exp          | 21 +++++-----
 sim/testsuite/frv/misc.exp                | 21 +++++-----
 sim/testsuite/frv/parallel.exp            | 21 +++++-----
 sim/testsuite/ft32/allinsn.exp            | 17 ++++----
 sim/testsuite/h8300/allinsn.exp           | 16 +++-----
 sim/testsuite/iq2000/allinsn.exp          | 17 ++++----
 sim/testsuite/lm32/allinsn.exp            | 17 ++++----
 sim/testsuite/m32c/allinsn.exp            | 17 ++++----
 sim/testsuite/m32r/allinsn.exp            | 23 +++++------
 sim/testsuite/m32r/misc.exp               | 23 +++++------
 sim/testsuite/m68hc11/allinsn.exp         | 17 ++++----
 sim/testsuite/mcore/allinsn.exp           | 17 ++++----
 sim/testsuite/microblaze/allinsn.exp      | 17 ++++----
 sim/testsuite/mn10300/allinsn.exp         | 17 ++++----
 sim/testsuite/moxie/allinsn.exp           | 17 ++++----
 sim/testsuite/msp430/allinsn.exp          | 17 ++++----
 sim/testsuite/or1k/alltests.exp           | 19 ++++-----
 sim/testsuite/pru/allinsn.exp             | 17 ++++----
 sim/testsuite/riscv/allinsn.exp           | 17 ++++----
 sim/testsuite/sh/allinsn.exp              |  6 +--
 sim/testsuite/v850/allinsns.exp           | 29 ++++++--------
 46 files changed, 332 insertions(+), 467 deletions(-)

diff --git a/sim/testsuite/aarch64/allinsn.exp b/sim/testsuite/aarch64/allinsn.exp
index e09d15739b3d..abc11462f095 100644
--- a/sim/testsuite/aarch64/allinsn.exp
+++ b/sim/testsuite/aarch64/allinsn.exp
@@ -2,16 +2,13 @@
 
 sim_init
 
-if [istarget *] {
-    # all machines
-    set all_machs "aarch64"
+# all machines
+set all_machs "aarch64"
 
-    foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
-	# If we're only testing specific files and this isn't one of them,
-	# skip it.
-	if ![runtest_file_p $runtests $src] {
-	    continue
-	}
-	run_sim_test $src $all_machs
+foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
+    # If we're only testing specific files and this isn't one of them, skip it.
+    if ![runtest_file_p $runtests $src] {
+	continue
     }
+    run_sim_test $src $all_machs
 }
diff --git a/sim/testsuite/arm/allinsn.exp b/sim/testsuite/arm/allinsn.exp
index da28b69e51a6..95a5759a5689 100644
--- a/sim/testsuite/arm/allinsn.exp
+++ b/sim/testsuite/arm/allinsn.exp
@@ -2,18 +2,14 @@
 
 sim_init
 
-if { [istarget *] } {
-    # all machines
-    set all_machs "xscale"
-
-    # The .cgs suffix is for "cgen .s".
-    foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.cgs]] {
-	# If we're only testing specific files and this isn't one of them,
-	# skip it.
-	if ![runtest_file_p $runtests $src] {
-	    continue
-	}
-
-	run_sim_test $src $all_machs
+# all machines
+set all_machs "xscale"
+
+# The .cgs suffix is for "cgen .s".
+foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.cgs]] {
+    # If we're only testing specific files and this isn't one of them, skip it.
+    if ![runtest_file_p $runtests $src] {
+	continue
     }
+    run_sim_test $src $all_machs
 }
diff --git a/sim/testsuite/arm/iwmmxt/iwmmxt.exp b/sim/testsuite/arm/iwmmxt/iwmmxt.exp
index 19a78a201ed7..3e0fb333429a 100644
--- a/sim/testsuite/arm/iwmmxt/iwmmxt.exp
+++ b/sim/testsuite/arm/iwmmxt/iwmmxt.exp
@@ -2,18 +2,14 @@
 
 sim_init
 
-if { [istarget *] } {
-    # all machines
-    set all_machs "xscale"
-
-    # The .cgs suffix is for "cgen .s".
-    foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.cgs]] {
-	# If we're only testing specific files and this isn't one of them,
-	# skip it.
-	if ![runtest_file_p $runtests $src] {
-	    continue
-	}
-
-	run_sim_test $src $all_machs
+# all machines
+set all_machs "xscale"
+
+# The .cgs suffix is for "cgen .s".
+foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.cgs]] {
+    # If we're only testing specific files and this isn't one of them, skip it.
+    if ![runtest_file_p $runtests $src] {
+	continue
     }
+    run_sim_test $src $all_machs
 }
diff --git a/sim/testsuite/arm/misc.exp b/sim/testsuite/arm/misc.exp
index 47d714cce2f9..5ba5f648bb17 100644
--- a/sim/testsuite/arm/misc.exp
+++ b/sim/testsuite/arm/misc.exp
@@ -2,18 +2,14 @@
 
 sim_init
 
-if { [istarget *] } {
-    # all machines
-    set all_machs "arm7tdmi"
-
-    # The .ms suffix is for "miscellaneous .s".
-    foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.ms]] {
-	# If we're only testing specific files and this isn't one of them,
-	# skip it.
-	if ![runtest_file_p $runtests $src] {
-	    continue
-	}
-
-	run_sim_test $src $all_machs
+# all machines
+set all_machs "arm7tdmi"
+
+# The .ms suffix is for "miscellaneous .s".
+foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.ms]] {
+    # If we're only testing specific files and this isn't one of them, skip it.
+    if ![runtest_file_p $runtests $src] {
+	continue
     }
+    run_sim_test $src $all_machs
 }
diff --git a/sim/testsuite/arm/thumb/allthumb.exp b/sim/testsuite/arm/thumb/allthumb.exp
index 36eb29c08f0f..db1d00d1318f 100644
--- a/sim/testsuite/arm/thumb/allthumb.exp
+++ b/sim/testsuite/arm/thumb/allthumb.exp
@@ -2,18 +2,14 @@
 
 sim_init
 
-if { [istarget *] } {
-    # all machines
-    set all_machs "arm7tdmi"
-
-    # The .cgs suffix is for "cgen .s".
-    foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.cgs]] {
-	# If we're only testing specific files and this isn't one of them,
-	# skip it.
-	if ![runtest_file_p $runtests $src] {
-	    continue
-	}
-
-	run_sim_test $src $all_machs
+# all machines
+set all_machs "arm7tdmi"
+
+# The .cgs suffix is for "cgen .s".
+foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.cgs]] {
+    # If we're only testing specific files and this isn't one of them, skip it.
+    if ![runtest_file_p $runtests $src] {
+	continue
     }
+    run_sim_test $src $all_machs
 }
diff --git a/sim/testsuite/arm/xscale/xscale.exp b/sim/testsuite/arm/xscale/xscale.exp
index 80faf5c119fd..0e5a7549b542 100644
--- a/sim/testsuite/arm/xscale/xscale.exp
+++ b/sim/testsuite/arm/xscale/xscale.exp
@@ -2,18 +2,14 @@
 
 sim_init
 
-if { [istarget *] } {
-    # all machines
-    set all_machs "xscale"
-
-    # The .cgs suffix is for "cgen .s".
-    foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.cgs]] {
-	# If we're only testing specific files and this isn't one of them,
-	# skip it.
-	if ![runtest_file_p $runtests $src] {
-	    continue
-	}
-
-	run_sim_test $src $all_machs
+# all machines
+set all_machs "xscale"
+
+# The .cgs suffix is for "cgen .s".
+foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.cgs]] {
+    # If we're only testing specific files and this isn't one of them, skip it.
+    if ![runtest_file_p $runtests $src] {
+	continue
     }
+    run_sim_test $src $all_machs
 }
diff --git a/sim/testsuite/avr/allinsn.exp b/sim/testsuite/avr/allinsn.exp
index 56b6e396881d..4664686fb5aa 100644
--- a/sim/testsuite/avr/allinsn.exp
+++ b/sim/testsuite/avr/allinsn.exp
@@ -2,16 +2,13 @@
 
 sim_init
 
-if [istarget *] {
-    # all machines
-    set all_machs "avr"
+# all machines
+set all_machs "avr"
 
-    foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
-	# If we're only testing specific files and this isn't one of them,
-	# skip it.
-	if ![runtest_file_p $runtests $src] {
-	    continue
-	}
-	run_sim_test $src $all_machs
+foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
+    # If we're only testing specific files and this isn't one of them, skip it.
+    if ![runtest_file_p $runtests $src] {
+	continue
     }
+    run_sim_test $src $all_machs
 }
diff --git a/sim/testsuite/bfin/allinsn.exp b/sim/testsuite/bfin/allinsn.exp
index d6a45304e36c..fccad36c8665 100644
--- a/sim/testsuite/bfin/allinsn.exp
+++ b/sim/testsuite/bfin/allinsn.exp
@@ -6,16 +6,13 @@ global CFLAGS_FOR_TARGET_init
 set CFLAGS_FOR_TARGET_init "-mcpu=bf537"
 sim_init
 
-if [istarget *] {
-    # all machines
-    set all_machs "bfin"
+# all machines
+set all_machs "bfin"
 
-    foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.\[csS\]]] {
-	# If we're only testing specific files and this isn't one of them,
-	# skip it.
-	if ![runtest_file_p $runtests $src] {
-	    continue
-	}
-	run_sim_test $src $all_machs
+foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.\[csS\]]] {
+    # If we're only testing specific files and this isn't one of them, skip it.
+    if ![runtest_file_p $runtests $src] {
+	continue
     }
+    run_sim_test $src $all_machs
 }
diff --git a/sim/testsuite/bpf/allinsn.exp b/sim/testsuite/bpf/allinsn.exp
index 88752b8e568d..98f0346776a7 100644
--- a/sim/testsuite/bpf/allinsn.exp
+++ b/sim/testsuite/bpf/allinsn.exp
@@ -2,23 +2,19 @@
 
 sim_init
 
-if [istarget *] {
-    # all machines
-    set all_machs "bpf"
+# all machines
+set all_machs "bpf"
 
-    global SIMFLAGS_FOR_TARGET
-    set SIMFLAGS_FOR_TARGET "--memory-size=4Mb"
+global SIMFLAGS_FOR_TARGET
+set SIMFLAGS_FOR_TARGET "--memory-size=4Mb"
 
-    global LDFLAGS_FOR_TARGET
-    set LDFLAGS_FOR_TARGET "-Ttext=0x0"
+global LDFLAGS_FOR_TARGET
+set LDFLAGS_FOR_TARGET "-Ttext=0x0"
 
-    foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
-	# If we're only testing specific files and this isn't one of them,
-	# skip it.
-	if ![runtest_file_p $runtests $src] {
-	    continue
-	}
-
-	run_sim_test $src $all_machs
+foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
+    # If we're only testing specific files and this isn't one of them, skip it.
+    if ![runtest_file_p $runtests $src] {
+	continue
     }
+    run_sim_test $src $all_machs
 }
diff --git a/sim/testsuite/cr16/allinsn.exp b/sim/testsuite/cr16/allinsn.exp
index 39b464a85ffc..1bdda16635b0 100644
--- a/sim/testsuite/cr16/allinsn.exp
+++ b/sim/testsuite/cr16/allinsn.exp
@@ -2,23 +2,19 @@
 
 sim_init
 
-if [istarget *] {
-    # all machines
-    set all_machs "cr16"
+# all machines
+set all_machs "cr16"
 
-    global SIMFLAGS_FOR_TARGET
-    # The cr16 linker sets the default LMA base to 0, and all the code
-    # expects the VMA when running, so use that when running the tests.
-    set SIMFLAGS_FOR_TARGET "--load-vma"
+global SIMFLAGS_FOR_TARGET
+# The cr16 linker sets the default LMA base to 0, and all the code
+# expects the VMA when running, so use that when running the tests.
+set SIMFLAGS_FOR_TARGET "--load-vma"
 
-    # The .cgs suffix is for "cgen .s".
-    foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.cgs]] {
-	# If we're only testing specific files and this isn't one of them,
-	# skip it.
-	if ![runtest_file_p $runtests $src] {
-	    continue
-	}
-
-	run_sim_test $src $all_machs
+# The .cgs suffix is for "cgen .s".
+foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.cgs]] {
+    # If we're only testing specific files and this isn't one of them, skip it.
+    if ![runtest_file_p $runtests $src] {
+	continue
     }
+    run_sim_test $src $all_machs
 }
diff --git a/sim/testsuite/cr16/misc.exp b/sim/testsuite/cr16/misc.exp
index 4d42667b0a43..40cdd965cfb9 100644
--- a/sim/testsuite/cr16/misc.exp
+++ b/sim/testsuite/cr16/misc.exp
@@ -2,23 +2,19 @@
 
 sim_init
 
-if [istarget *] {
-    # all machines
-    set all_machs "cr16"
+# all machines
+set all_machs "cr16"
 
-    global SIMFLAGS_FOR_TARGET
-    # The cr16 linker sets the default LMA base to 0, and all the code
-    # expects the VMA when running, so use that when running the tests.
-    set SIMFLAGS_FOR_TARGET "--load-vma"
+global SIMFLAGS_FOR_TARGET
+# The cr16 linker sets the default LMA base to 0, and all the code
+# expects the VMA when running, so use that when running the tests.
+set SIMFLAGS_FOR_TARGET "--load-vma"
 
-    # The .ms suffix is for "miscellaneous .s".
-    foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.ms]] {
-	# If we're only testing specific files and this isn't one of them,
-	# skip it.
-	if ![runtest_file_p $runtests $src] {
-	    continue
-	}
-
-	run_sim_test $src $all_machs
+# The .ms suffix is for "miscellaneous .s".
+foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.ms]] {
+    # If we're only testing specific files and this isn't one of them, skip it.
+    if ![runtest_file_p $runtests $src] {
+	continue
     }
+    run_sim_test $src $all_machs
 }
diff --git a/sim/testsuite/cris/asm/asm.exp b/sim/testsuite/cris/asm/asm.exp
index 6fed30acbd86..fe6b373ac43d 100644
--- a/sim/testsuite/cris/asm/asm.exp
+++ b/sim/testsuite/cris/asm/asm.exp
@@ -17,31 +17,29 @@
 
 sim_init
 
-if [istarget *] {
-    global ASFLAGS_FOR_TARGET
-    # All machines we test and the corresponding assembler option.  Needs
-    # update if we build the simulator for crisv0 crisv3 and crisv8 too.
-
-    set combos {{"crisv10" "--march=v10 --no-mul-bug-abort"}
-                {"crisv32" "--march=v32"}}
-
-    # We need to pass different assembler flags for each machine.
-    # Specifying it here rather than adding a specifier to each and every
-    # test-file is preferrable.
-
-    foreach combo $combos {
-	set mach [lindex $combo 0]
-	set ASFLAGS_FOR_TARGET "[lindex $combo 1]"
-
-	# The .ms suffix is for "miscellaneous .s".
-	foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.ms]] {
-	    # If we're only testing specific files and this isn't one of them,
-	    # skip it.
-	    if ![runtest_file_p $runtests $src] {
-		continue
-	    }
-
-	    run_sim_test $src $mach
+global ASFLAGS_FOR_TARGET
+# All machines we test and the corresponding assembler option.  Needs
+# update if we build the simulator for crisv0 crisv3 and crisv8 too.
+
+set combos {{"crisv10" "--march=v10 --no-mul-bug-abort"}
+	    {"crisv32" "--march=v32"}}
+
+# We need to pass different assembler flags for each machine.
+# Specifying it here rather than adding a specifier to each and every
+# test-file is preferrable.
+
+foreach combo $combos {
+    set mach [lindex $combo 0]
+    set ASFLAGS_FOR_TARGET "[lindex $combo 1]"
+
+    # The .ms suffix is for "miscellaneous .s".
+    foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.ms]] {
+	# If we're only testing specific files and this isn't one of them,
+	# skip it.
+	if ![runtest_file_p $runtests $src] {
+	    continue
 	}
+
+	run_sim_test $src $mach
     }
 }
diff --git a/sim/testsuite/d10v/allinsn.exp b/sim/testsuite/d10v/allinsn.exp
index 97265a15db7b..430c22e2606d 100644
--- a/sim/testsuite/d10v/allinsn.exp
+++ b/sim/testsuite/d10v/allinsn.exp
@@ -2,16 +2,13 @@
 
 sim_init
 
-if [istarget *] {
-    # all machines
-    set all_machs "d10v"
+# all machines
+set all_machs "d10v"
 
-    foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
-	# If we're only testing specific files and this isn't one of them,
-	# skip it.
-	if ![runtest_file_p $runtests $src] {
-	    continue
-	}
-	run_sim_test $src $all_machs
+foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
+    # If we're only testing specific files and this isn't one of them, skip it.
+    if ![runtest_file_p $runtests $src] {
+	continue
     }
+    run_sim_test $src $all_machs
 }
diff --git a/sim/testsuite/example-synacor/allinsn.exp b/sim/testsuite/example-synacor/allinsn.exp
index 07401ced9bb4..f751f3117e7c 100644
--- a/sim/testsuite/example-synacor/allinsn.exp
+++ b/sim/testsuite/example-synacor/allinsn.exp
@@ -2,19 +2,16 @@
 
 sim_init
 
-if [istarget *] {
-    # All machines.
-    set all_machs "example"
+# All machines.
+set all_machs "example"
 
-    global LDFLAGS_FOR_TARGET
-    set LDFLAGS_FOR_TARGET "-Ttext=0"
+global LDFLAGS_FOR_TARGET
+set LDFLAGS_FOR_TARGET "-Ttext=0"
 
-    foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
-	# If we're only testing specific files and this isn't one of them,
-	# skip it.
-	if ![runtest_file_p $runtests $src] {
-	    continue
-	}
-	run_sim_test $src $all_machs
+foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
+    # If we're only testing specific files and this isn't one of them, skip it.
+    if ![runtest_file_p $runtests $src] {
+	continue
     }
+    run_sim_test $src $all_machs
 }
diff --git a/sim/testsuite/frv/allinsn-a-b.exp b/sim/testsuite/frv/allinsn-a-b.exp
index c24cd42fb196..6831231e3301 100644
--- a/sim/testsuite/frv/allinsn-a-b.exp
+++ b/sim/testsuite/frv/allinsn-a-b.exp
@@ -8,8 +8,7 @@ set cpu_option -mcpu
 
 # The .cgs suffix is for "cgen .s".
 foreach src [lsort [glob -nocomplain $srcdir/$subdir/\[a-b\]*.cgs]] {
-    # If we're only testing specific files and this isn't one of them,
-    # skip it.
+    # If we're only testing specific files and this isn't one of them, skip it.
     if ![runtest_file_p $runtests $src] {
 	continue
     }
diff --git a/sim/testsuite/frv/allinsn-c.exp b/sim/testsuite/frv/allinsn-c.exp
index e1672e8f2736..2d82fb47544a 100644
--- a/sim/testsuite/frv/allinsn-c.exp
+++ b/sim/testsuite/frv/allinsn-c.exp
@@ -8,8 +8,7 @@ set cpu_option -mcpu
 
 # The .cgs suffix is for "cgen .s".
 foreach src [lsort [glob -nocomplain $srcdir/$subdir/\[c\]*.cgs]] {
-    # If we're only testing specific files and this isn't one of them,
-    # skip it.
+    # If we're only testing specific files and this isn't one of them, skip it.
     if ![runtest_file_p $runtests $src] {
 	continue
     }
diff --git a/sim/testsuite/frv/allinsn-d-h.exp b/sim/testsuite/frv/allinsn-d-h.exp
index 8c29369035a2..42645e1c6588 100644
--- a/sim/testsuite/frv/allinsn-d-h.exp
+++ b/sim/testsuite/frv/allinsn-d-h.exp
@@ -8,8 +8,7 @@ set cpu_option -mcpu
 
 # The .cgs suffix is for "cgen .s".
 foreach src [lsort [glob -nocomplain $srcdir/$subdir/\[d-h\]*.cgs]] {
-    # If we're only testing specific files and this isn't one of them,
-    # skip it.
+    # If we're only testing specific files and this isn't one of them, skip it.
     if ![runtest_file_p $runtests $src] {
 	continue
     }
diff --git a/sim/testsuite/frv/allinsn-i-l.exp b/sim/testsuite/frv/allinsn-i-l.exp
index 10b8793ceee5..faa07cde1eac 100644
--- a/sim/testsuite/frv/allinsn-i-l.exp
+++ b/sim/testsuite/frv/allinsn-i-l.exp
@@ -8,8 +8,7 @@ set cpu_option -mcpu
 
 # The .cgs suffix is for "cgen .s".
 foreach src [lsort [glob -nocomplain $srcdir/$subdir/\[i-l\]*.cgs]] {
-    # If we're only testing specific files and this isn't one of them,
-    # skip it.
+    # If we're only testing specific files and this isn't one of them, skip it.
     if ![runtest_file_p $runtests $src] {
 	continue
     }
diff --git a/sim/testsuite/frv/allinsn-m.exp b/sim/testsuite/frv/allinsn-m.exp
index e3733e05550a..aba950773758 100644
--- a/sim/testsuite/frv/allinsn-m.exp
+++ b/sim/testsuite/frv/allinsn-m.exp
@@ -8,8 +8,7 @@ set cpu_option -mcpu
 
 # The .cgs suffix is for "cgen .s".
 foreach src [lsort [glob -nocomplain $srcdir/$subdir/\[m\]*.cgs]] {
-    # If we're only testing specific files and this isn't one of them,
-    # skip it.
+    # If we're only testing specific files and this isn't one of them, skip it.
     if ![runtest_file_p $runtests $src] {
 	continue
     }
diff --git a/sim/testsuite/frv/allinsn-n.exp b/sim/testsuite/frv/allinsn-n.exp
index e6c41b414f62..3b41fef32126 100644
--- a/sim/testsuite/frv/allinsn-n.exp
+++ b/sim/testsuite/frv/allinsn-n.exp
@@ -8,8 +8,7 @@ set cpu_option -mcpu
 
 # The .cgs suffix is for "cgen .s".
 foreach src [lsort [glob -nocomplain $srcdir/$subdir/\[n\]*.cgs]] {
-    # If we're only testing specific files and this isn't one of them,
-    # skip it.
+    # If we're only testing specific files and this isn't one of them, skip it.
     if ![runtest_file_p $runtests $src] {
 	continue
     }
diff --git a/sim/testsuite/frv/allinsn-o-s.exp b/sim/testsuite/frv/allinsn-o-s.exp
index 98906e81bc41..6e172fc38d0e 100644
--- a/sim/testsuite/frv/allinsn-o-s.exp
+++ b/sim/testsuite/frv/allinsn-o-s.exp
@@ -8,8 +8,7 @@ set cpu_option -mcpu
 
 # The .cgs suffix is for "cgen .s".
 foreach src [lsort [glob -nocomplain $srcdir/$subdir/\[o-s\]*.cgs]] {
-    # If we're only testing specific files and this isn't one of them,
-    # skip it.
+    # If we're only testing specific files and this isn't one of them, skip it.
     if ![runtest_file_p $runtests $src] {
 	continue
     }
diff --git a/sim/testsuite/frv/allinsn-t-z.exp b/sim/testsuite/frv/allinsn-t-z.exp
index 04b0e5709cb1..52610c2ab8e3 100644
--- a/sim/testsuite/frv/allinsn-t-z.exp
+++ b/sim/testsuite/frv/allinsn-t-z.exp
@@ -8,8 +8,7 @@ set cpu_option -mcpu
 
 # The .cgs suffix is for "cgen .s".
 foreach src [lsort [glob -nocomplain $srcdir/$subdir/\[t-z\]*.cgs]] {
-    # If we're only testing specific files and this isn't one of them,
-    # skip it.
+    # If we're only testing specific files and this isn't one of them, skip it.
     if ![runtest_file_p $runtests $src] {
 	continue
     }
diff --git a/sim/testsuite/frv/fr400/allinsn.exp b/sim/testsuite/frv/fr400/allinsn.exp
index 4f92f227d925..b4fa18630c56 100644
--- a/sim/testsuite/frv/fr400/allinsn.exp
+++ b/sim/testsuite/frv/fr400/allinsn.exp
@@ -2,18 +2,15 @@
 
 sim_init
 
-if [istarget *] {
-    # all machines
-    set all_machs "fr400 fr405 fr450 fr550"
-    set cpu_option -mcpu
+# all machines
+set all_machs "fr400 fr405 fr450 fr550"
+set cpu_option -mcpu
 
-    # The .cgs suffix is for "cgen .s".
-    foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.cgs]] {
-	# If we're only testing specific files and this isn't one of them,
-	# skip it.
-	if ![runtest_file_p $runtests $src] {
-	    continue
-	}
-	run_sim_test $src $all_machs
+# The .cgs suffix is for "cgen .s".
+foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.cgs]] {
+    # If we're only testing specific files and this isn't one of them, skip it.
+    if ![runtest_file_p $runtests $src] {
+	continue
     }
+    run_sim_test $src $all_machs
 }
diff --git a/sim/testsuite/frv/fr500/allinsn.exp b/sim/testsuite/frv/fr500/allinsn.exp
index ec1309a24411..4e7360cb445e 100644
--- a/sim/testsuite/frv/fr500/allinsn.exp
+++ b/sim/testsuite/frv/fr500/allinsn.exp
@@ -2,18 +2,15 @@
 
 sim_init
 
-if [istarget *] {
-    # all machines
-    set all_machs "frv fr500 fr550"
-    set cpu_option -mcpu
+# all machines
+set all_machs "frv fr500 fr550"
+set cpu_option -mcpu
 
-    # The .cgs suffix is for "cgen .s".
-    foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.cgs]] {
-	# If we're only testing specific files and this isn't one of them,
-	# skip it.
-	if ![runtest_file_p $runtests $src] {
-	    continue
-	}
-	run_sim_test $src $all_machs
+# The .cgs suffix is for "cgen .s".
+foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.cgs]] {
+    # If we're only testing specific files and this isn't one of them, skip it.
+    if ![runtest_file_p $runtests $src] {
+	continue
     }
+    run_sim_test $src $all_machs
 }
diff --git a/sim/testsuite/frv/fr550/allinsn.exp b/sim/testsuite/frv/fr550/allinsn.exp
index 56df37d427dc..6b4ce7774cde 100644
--- a/sim/testsuite/frv/fr550/allinsn.exp
+++ b/sim/testsuite/frv/fr550/allinsn.exp
@@ -2,18 +2,15 @@
 
 sim_init
 
-if [istarget *] {
-    # all machines
-    set all_machs "fr550"
-    set cpu_option -mcpu
+# all machines
+set all_machs "fr550"
+set cpu_option -mcpu
 
-    # The .cgs suffix is for "cgen .s".
-    foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.cgs]] {
-	# If we're only testing specific files and this isn't one of them,
-	# skip it.
-	if ![runtest_file_p $runtests $src] {
-	    continue
-	}
-	run_sim_test $src $all_machs
+# The .cgs suffix is for "cgen .s".
+foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.cgs]] {
+    # If we're only testing specific files and this isn't one of them, skip it.
+    if ![runtest_file_p $runtests $src] {
+	continue
     }
+    run_sim_test $src $all_machs
 }
diff --git a/sim/testsuite/frv/interrupts.exp b/sim/testsuite/frv/interrupts.exp
index ec83de422ea8..fe88591acf98 100644
--- a/sim/testsuite/frv/interrupts.exp
+++ b/sim/testsuite/frv/interrupts.exp
@@ -2,18 +2,15 @@
 
 sim_init
 
-if [istarget *] {
-    # all machines
-    set all_machs "frv fr500 fr550 fr400"
-    set cpu_option -mcpu
+# all machines
+set all_machs "frv fr500 fr550 fr400"
+set cpu_option -mcpu
 
-    # The .cgs suffix is for "cgen .s".
-    foreach src [lsort [glob -nocomplain $srcdir/$subdir/interrupts/*.cgs]] {
-	# If we're only testing specific files and this isn't one of them,
-	# skip it.
-	if ![runtest_file_p $runtests $src] {
-	    continue
-	}
-	run_sim_test $src $all_machs
+# The .cgs suffix is for "cgen .s".
+foreach src [lsort [glob -nocomplain $srcdir/$subdir/interrupts/*.cgs]] {
+    # If we're only testing specific files and this isn't one of them, skip it.
+    if ![runtest_file_p $runtests $src] {
+	continue
     }
+    run_sim_test $src $all_machs
 }
diff --git a/sim/testsuite/frv/misc.exp b/sim/testsuite/frv/misc.exp
index 21877f963381..b5cacf807467 100644
--- a/sim/testsuite/frv/misc.exp
+++ b/sim/testsuite/frv/misc.exp
@@ -2,18 +2,15 @@
 
 sim_init
 
-if [istarget *] {
-    # all machines
-    set all_machs "frv fr500 fr550 fr400 fr405 fr450"
-    set cpu_option -mcpu
+# all machines
+set all_machs "frv fr500 fr550 fr400 fr405 fr450"
+set cpu_option -mcpu
 
-    # The .ms suffix is for "miscellaneous .s".
-    foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.ms]] {
-	# If we're only testing specific files and this isn't one of them,
-	# skip it.
-	if ![runtest_file_p $runtests $src] {
-	    continue
-	}
-	run_sim_test $src $all_machs
+# The .ms suffix is for "miscellaneous .s".
+foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.ms]] {
+    # If we're only testing specific files and this isn't one of them, skip it.
+    if ![runtest_file_p $runtests $src] {
+	continue
     }
+    run_sim_test $src $all_machs
 }
diff --git a/sim/testsuite/frv/parallel.exp b/sim/testsuite/frv/parallel.exp
index 00bcccd66efb..5fe27087ef35 100644
--- a/sim/testsuite/frv/parallel.exp
+++ b/sim/testsuite/frv/parallel.exp
@@ -2,18 +2,15 @@
 
 sim_init
 
-if [istarget *] {
-    # all machines
-    set all_machs "frv fr500 fr550 fr400"
-    set cpu_option -mcpu
+# all machines
+set all_machs "frv fr500 fr550 fr400"
+set cpu_option -mcpu
 
-    # The .pcgs suffix is for "parallel cgen .s".
-    foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.pcgs]] {
-	# If we're only testing specific files and this isn't one of them,
-	# skip it.
-	if ![runtest_file_p $runtests $src] {
-	    continue
-	}
-	run_sim_test $src $all_machs
+# The .pcgs suffix is for "parallel cgen .s".
+foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.pcgs]] {
+    # If we're only testing specific files and this isn't one of them, skip it.
+    if ![runtest_file_p $runtests $src] {
+	continue
     }
+    run_sim_test $src $all_machs
 }
diff --git a/sim/testsuite/ft32/allinsn.exp b/sim/testsuite/ft32/allinsn.exp
index 260f13e1cebc..bd3a6bb10ac8 100644
--- a/sim/testsuite/ft32/allinsn.exp
+++ b/sim/testsuite/ft32/allinsn.exp
@@ -2,16 +2,13 @@
 
 sim_init
 
-if [istarget *] {
-    # all machines
-    set all_machs "ft32"
+# all machines
+set all_machs "ft32"
 
-    foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
-	# If we're only testing specific files and this isn't one of them,
-	# skip it.
-	if ![runtest_file_p $runtests $src] {
-	    continue
-	}
-	run_sim_test $src $all_machs
+foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
+    # If we're only testing specific files and this isn't one of them, skip it.
+    if ![runtest_file_p $runtests $src] {
+	continue
     }
+    run_sim_test $src $all_machs
 }
diff --git a/sim/testsuite/h8300/allinsn.exp b/sim/testsuite/h8300/allinsn.exp
index f270661f021e..4f0e6db91bff 100644
--- a/sim/testsuite/h8300/allinsn.exp
+++ b/sim/testsuite/h8300/allinsn.exp
@@ -2,16 +2,12 @@
 
 sim_init
 
-if {[istarget *]} {
-    set all_machs "h8300 h8300h h8300s h8sx"
+set all_machs "h8300 h8300h h8300s h8sx"
 
-    foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
-	# If we're only testing specific files and this isn't one of them,
-	# skip it.
-	if ![runtest_file_p $runtests $src] {
-	    continue
-	}
-
-	run_sim_test $src $all_machs
+foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
+    # If we're only testing specific files and this isn't one of them, skip it.
+    if ![runtest_file_p $runtests $src] {
+	continue
     }
+    run_sim_test $src $all_machs
 }
diff --git a/sim/testsuite/iq2000/allinsn.exp b/sim/testsuite/iq2000/allinsn.exp
index 30a1c94ea61d..554c6aedf5a4 100644
--- a/sim/testsuite/iq2000/allinsn.exp
+++ b/sim/testsuite/iq2000/allinsn.exp
@@ -2,16 +2,13 @@
 
 sim_init
 
-if [istarget *] {
-    # all machines
-    set all_machs "iq2000"
+# all machines
+set all_machs "iq2000"
 
-    foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
-	# If we're only testing specific files and this isn't one of them,
-	# skip it.
-	if ![runtest_file_p $runtests $src] {
-	    continue
-	}
-	run_sim_test $src $all_machs
+foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
+    # If we're only testing specific files and this isn't one of them, skip it.
+    if ![runtest_file_p $runtests $src] {
+	continue
     }
+    run_sim_test $src $all_machs
 }
diff --git a/sim/testsuite/lm32/allinsn.exp b/sim/testsuite/lm32/allinsn.exp
index fb5d4d3471e3..67c70ecadd1b 100644
--- a/sim/testsuite/lm32/allinsn.exp
+++ b/sim/testsuite/lm32/allinsn.exp
@@ -2,16 +2,13 @@
 
 sim_init
 
-if [istarget *] {
-    # all machines
-    set all_machs "lm32"
+# all machines
+set all_machs "lm32"
 
-    foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
-	# If we're only testing specific files and this isn't one of them,
-	# skip it.
-	if ![runtest_file_p $runtests $src] {
-	    continue
-	}
-	run_sim_test $src $all_machs
+foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
+    # If we're only testing specific files and this isn't one of them, skip it.
+    if ![runtest_file_p $runtests $src] {
+	continue
     }
+    run_sim_test $src $all_machs
 }
diff --git a/sim/testsuite/m32c/allinsn.exp b/sim/testsuite/m32c/allinsn.exp
index c979514f5dd8..4df54fb8c8f3 100644
--- a/sim/testsuite/m32c/allinsn.exp
+++ b/sim/testsuite/m32c/allinsn.exp
@@ -3,16 +3,13 @@
 
 sim_init
 
-if [istarget *] {
-    # all machines
-    set all_machs "m32c"
+# all machines
+set all_machs "m32c"
 
-    foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
-	# If we're only testing specific files and this isn't one of them,
-	# skip it.
-	if ![runtest_file_p $runtests $src] {
-	    continue
-	}
-	run_sim_test $src $all_machs
+foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
+    # If we're only testing specific files and this isn't one of them, skip it.
+    if ![runtest_file_p $runtests $src] {
+	continue
     }
+    run_sim_test $src $all_machs
 }
diff --git a/sim/testsuite/m32r/allinsn.exp b/sim/testsuite/m32r/allinsn.exp
index c20fc86558be..fb8646f8ccc2 100644
--- a/sim/testsuite/m32r/allinsn.exp
+++ b/sim/testsuite/m32r/allinsn.exp
@@ -2,19 +2,14 @@
 
 sim_init
 
-if [istarget *] {
-    # all machines
-    set all_machs "m32r"
-
-
-    # The .cgs suffix is for "cgen .s".
-    foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.cgs]] {
-	# If we're only testing specific files and this isn't one of them,
-	# skip it.
-	if ![runtest_file_p $runtests $src] {
-	    continue
-	}
-
-	run_sim_test $src $all_machs
+# all machines
+set all_machs "m32r"
+
+# The .cgs suffix is for "cgen .s".
+foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.cgs]] {
+    # If we're only testing specific files and this isn't one of them, skip it.
+    if ![runtest_file_p $runtests $src] {
+	continue
     }
+    run_sim_test $src $all_machs
 }
diff --git a/sim/testsuite/m32r/misc.exp b/sim/testsuite/m32r/misc.exp
index 2ca2c03018ba..c5a0c7d4404e 100644
--- a/sim/testsuite/m32r/misc.exp
+++ b/sim/testsuite/m32r/misc.exp
@@ -2,19 +2,14 @@
 
 sim_init
 
-if [istarget *] {
-    # all machines
-    set all_machs "m32r"
-
-
-    # The .ms suffix is for "miscellaneous .s".
-    foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.ms]] {
-	# If we're only testing specific files and this isn't one of them,
-	# skip it.
-	if ![runtest_file_p $runtests $src] {
-	    continue
-	}
-
-	run_sim_test $src $all_machs
+# all machines
+set all_machs "m32r"
+
+# The .ms suffix is for "miscellaneous .s".
+foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.ms]] {
+    # If we're only testing specific files and this isn't one of them, skip it.
+    if ![runtest_file_p $runtests $src] {
+	continue
     }
+    run_sim_test $src $all_machs
 }
diff --git a/sim/testsuite/m68hc11/allinsn.exp b/sim/testsuite/m68hc11/allinsn.exp
index 09653a00c45f..5a10cc5131cf 100644
--- a/sim/testsuite/m68hc11/allinsn.exp
+++ b/sim/testsuite/m68hc11/allinsn.exp
@@ -2,16 +2,13 @@
 
 sim_init
 
-if [istarget *] {
-    # all machines
-    set all_machs "m68hc11"
+# all machines
+set all_machs "m68hc11"
 
-    foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
-	# If we're only testing specific files and this isn't one of them,
-	# skip it.
-	if ![runtest_file_p $runtests $src] {
-	    continue
-	}
-	run_sim_test $src $all_machs
+foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
+    # If we're only testing specific files and this isn't one of them, skip it.
+    if ![runtest_file_p $runtests $src] {
+	continue
     }
+    run_sim_test $src $all_machs
 }
diff --git a/sim/testsuite/mcore/allinsn.exp b/sim/testsuite/mcore/allinsn.exp
index 64747752a8e5..3333fdc3aeda 100644
--- a/sim/testsuite/mcore/allinsn.exp
+++ b/sim/testsuite/mcore/allinsn.exp
@@ -2,16 +2,13 @@
 
 sim_init
 
-if [istarget *] {
-    # all machines
-    set all_machs "mcore"
+# all machines
+set all_machs "mcore"
 
-    foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
-	# If we're only testing specific files and this isn't one of them,
-	# skip it.
-	if ![runtest_file_p $runtests $src] {
-	    continue
-	}
-	run_sim_test $src $all_machs
+foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
+    # If we're only testing specific files and this isn't one of them, skip it.
+    if ![runtest_file_p $runtests $src] {
+	continue
     }
+    run_sim_test $src $all_machs
 }
diff --git a/sim/testsuite/microblaze/allinsn.exp b/sim/testsuite/microblaze/allinsn.exp
index 3f582b033d3d..97dc6ec46249 100644
--- a/sim/testsuite/microblaze/allinsn.exp
+++ b/sim/testsuite/microblaze/allinsn.exp
@@ -2,16 +2,13 @@
 
 sim_init
 
-if [istarget *] {
-    # all machines
-    set all_machs "microblaze"
+# all machines
+set all_machs "microblaze"
 
-    foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
-	# If we're only testing specific files and this isn't one of them,
-	# skip it.
-	if ![runtest_file_p $runtests $src] {
-	    continue
-	}
-	run_sim_test $src $all_machs
+foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
+    # If we're only testing specific files and this isn't one of them, skip it.
+    if ![runtest_file_p $runtests $src] {
+	continue
     }
+    run_sim_test $src $all_machs
 }
diff --git a/sim/testsuite/mn10300/allinsn.exp b/sim/testsuite/mn10300/allinsn.exp
index 3e5903ac7ba0..96a1c150c6de 100644
--- a/sim/testsuite/mn10300/allinsn.exp
+++ b/sim/testsuite/mn10300/allinsn.exp
@@ -2,16 +2,13 @@
 
 sim_init
 
-if [istarget *] {
-    # all machines
-    set all_machs "mn10300"
+# all machines
+set all_machs "mn10300"
 
-    foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
-	# If we're only testing specific files and this isn't one of them,
-	# skip it.
-	if ![runtest_file_p $runtests $src] {
-	    continue
-	}
-	run_sim_test $src $all_machs
+foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
+    # If we're only testing specific files and this isn't one of them, skip it.
+    if ![runtest_file_p $runtests $src] {
+	continue
     }
+    run_sim_test $src $all_machs
 }
diff --git a/sim/testsuite/moxie/allinsn.exp b/sim/testsuite/moxie/allinsn.exp
index 3f2f0a7ac3fa..30871685a204 100644
--- a/sim/testsuite/moxie/allinsn.exp
+++ b/sim/testsuite/moxie/allinsn.exp
@@ -2,16 +2,13 @@
 
 sim_init
 
-if [istarget *] {
-    # all machines
-    set all_machs "moxie"
+# all machines
+set all_machs "moxie"
 
-    foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
-	# If we're only testing specific files and this isn't one of them,
-	# skip it.
-	if ![runtest_file_p $runtests $src] {
-	    continue
-	}
-	run_sim_test $src $all_machs
+foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
+    # If we're only testing specific files and this isn't one of them, skip it.
+    if ![runtest_file_p $runtests $src] {
+	continue
     }
+    run_sim_test $src $all_machs
 }
diff --git a/sim/testsuite/msp430/allinsn.exp b/sim/testsuite/msp430/allinsn.exp
index 888afa918d84..ee56936cb900 100644
--- a/sim/testsuite/msp430/allinsn.exp
+++ b/sim/testsuite/msp430/allinsn.exp
@@ -2,16 +2,13 @@
 
 sim_init
 
-if [istarget *] {
-    # all machines
-    set all_machs "msp430"
+# all machines
+set all_machs "msp430"
 
-    foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
-	# If we're only testing specific files and this isn't one of them,
-	# skip it.
-	if ![runtest_file_p $runtests $src] {
-	    continue
-	}
-	run_sim_test $src $all_machs
+foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
+    # If we're only testing specific files and this isn't one of them, skip it.
+    if ![runtest_file_p $runtests $src] {
+	continue
     }
+    run_sim_test $src $all_machs
 }
diff --git a/sim/testsuite/or1k/alltests.exp b/sim/testsuite/or1k/alltests.exp
index 1b26e5b20190..15a7fd47c792 100644
--- a/sim/testsuite/or1k/alltests.exp
+++ b/sim/testsuite/or1k/alltests.exp
@@ -17,19 +17,14 @@
 
 sim_init
 
-if [istarget *] {
-    set all_machs "or1k"
+set all_machs "or1k"
 
-    global LDFLAGS_FOR_TARGET
-    set LDFLAGS_FOR_TARGET "-T $srcdir/$subdir/or1k-test.ld"
+global LDFLAGS_FOR_TARGET
+set LDFLAGS_FOR_TARGET "-T $srcdir/$subdir/or1k-test.ld"
 
-    foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.S]] {
-
-	if ![runtest_file_p $runtests $src] {
-	    continue
-	}
-
-	run_sim_test $src $all_machs
+foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.S]] {
+    if ![runtest_file_p $runtests $src] {
+	continue
     }
-
+    run_sim_test $src $all_machs
 }
diff --git a/sim/testsuite/pru/allinsn.exp b/sim/testsuite/pru/allinsn.exp
index 9b98e22e7284..465582f56377 100644
--- a/sim/testsuite/pru/allinsn.exp
+++ b/sim/testsuite/pru/allinsn.exp
@@ -20,16 +20,13 @@
 
 sim_init
 
-if [istarget *] {
-    # all machines
-    set all_machs "pru"
+# all machines
+set all_machs "pru"
 
-    foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
-	# If we're only testing specific files and this isn't one of them,
-	# skip it.
-	if ![runtest_file_p $runtests $src] {
-	    continue
-	}
-	run_sim_test $src $all_machs
+foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
+    # If we're only testing specific files and this isn't one of them, skip it.
+    if ![runtest_file_p $runtests $src] {
+	continue
     }
+    run_sim_test $src $all_machs
 }
diff --git a/sim/testsuite/riscv/allinsn.exp b/sim/testsuite/riscv/allinsn.exp
index db310c30ea58..972edf4d5ecf 100644
--- a/sim/testsuite/riscv/allinsn.exp
+++ b/sim/testsuite/riscv/allinsn.exp
@@ -2,16 +2,13 @@
 
 sim_init
 
-if [istarget *] {
-    # all machines
-    set all_machs "riscv"
+# all machines
+set all_machs "riscv"
 
-    foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
-	# If we're only testing specific files and this isn't one of them,
-	# skip it.
-	if ![runtest_file_p $runtests $src] {
-	    continue
-	}
-	run_sim_test $src $all_machs
+foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
+    # If we're only testing specific files and this isn't one of them, skip it.
+    if ![runtest_file_p $runtests $src] {
+	continue
     }
+    run_sim_test $src $all_machs
 }
diff --git a/sim/testsuite/sh/allinsn.exp b/sim/testsuite/sh/allinsn.exp
index 69d324ae91d9..4eabdf2602c9 100644
--- a/sim/testsuite/sh/allinsn.exp
+++ b/sim/testsuite/sh/allinsn.exp
@@ -14,8 +14,6 @@ foreach opt $board_variant_list {
     }
 }
 
-if [istarget *] {
-    foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
-	run_sim_test $src $all_machs
-    }
+foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
+    run_sim_test $src $all_machs
 }
diff --git a/sim/testsuite/v850/allinsns.exp b/sim/testsuite/v850/allinsns.exp
index 1aa80249f9db..4cc461c30fd6 100644
--- a/sim/testsuite/v850/allinsns.exp
+++ b/sim/testsuite/v850/allinsns.exp
@@ -2,23 +2,20 @@
 
 sim_init
 
-if [istarget *] {
-    # All machines.
-    # Should add more cpus if the testsuite adds coverage for their insns, but
-    # at the core level, there's no deviation beyond these two.
-    set all_machs "v850e v850"
+# All machines.
+# Should add more cpus if the testsuite adds coverage for their insns, but
+# at the core level, there's no deviation beyond these two.
+set all_machs "v850e v850"
 
-    # gas doesn't support any '=' option for v850.
-    set cpu_option_sep ""
-    set cpu_option -m
+# gas doesn't support any '=' option for v850.
+set cpu_option_sep ""
+set cpu_option -m
 
-    # The .cgs suffix is for "cgen .s".
-    foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.cgs]] {
-	# If we're only testing specific files and this isn't one of them,
-	# skip it.
-	if ![runtest_file_p $runtests $src] {
-	    continue
-	}
-	run_sim_test $src $all_machs
+# The .cgs suffix is for "cgen .s".
+foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.cgs]] {
+    # If we're only testing specific files and this isn't one of them, skip it.
+    if ![runtest_file_p $runtests $src] {
+	continue
     }
+    run_sim_test $src $all_machs
 }
-- 
2.34.1


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-02-16  5:45 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-16  5:44 [PATCH/committed] sim: testsuite: cleanup the istarget * logic Mike Frysinger via Gdb-patches

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox