[PATCH] gdb-add-index: disable debuginfod

[PATCH] gdb-add-index: disable debuginfod

[Aaron Merey via Gdb-patches]

gdb-add-index may trigger debuginfod's first-use notice.  The notice
is misleading in this case.  It instructs the user to modify .gdbinit
in order to permanently enable/disable debuginfod but gdb-add-index
invokes gdb with -nx which ignores .gdbinit.

Additionally debuginfod is not needed for gdb-add-index since the
symbol file is given as an argument and should already be present
locally.

Fix this by disabling debuginfod when gdb-add-index invokes gdb.
---
 gdb/contrib/gdb-add-index.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gdb/contrib/gdb-add-index.sh b/gdb/contrib/gdb-add-index.sh
index 0ff943d506e..591f32bbbbe 100755
--- a/gdb/contrib/gdb-add-index.sh
+++ b/gdb/contrib/gdb-add-index.sh
@@ -112,6 +112,7 @@ rm -f $tmp_files
 trap "rm -f $tmp_files" 0
 
 $GDB --batch -nx -iex 'set auto-load no' \
+    -iex 'set debuginfod enabled off' \
     -ex "file $file" -ex "save gdb-index $dwarf5 $dir" || {
     # Just in case.
     status=$?
-- 
2.34.1

Re: [PATCH] gdb-add-index: disable debuginfod

[Tom Tromey]

>>>>> "Aaron" == Aaron Merey via Gdb-patches <gdb-patches@sourceware.org> writes:

Aaron> gdb-add-index may trigger debuginfod's first-use notice.  The notice
Aaron> is misleading in this case.  It instructs the user to modify .gdbinit
Aaron> in order to permanently enable/disable debuginfod but gdb-add-index
Aaron> invokes gdb with -nx which ignores .gdbinit.

Aaron> Additionally debuginfod is not needed for gdb-add-index since the
Aaron> symbol file is given as an argument and should already be present
Aaron> locally.

Aaron> Fix this by disabling debuginfod when gdb-add-index invokes gdb.

Thank you.  This is ok.

Tom

Re: [PATCH] gdb-add-index: disable debuginfod

[Aaron Merey via Gdb-patches]

On Fri, Feb 25, 2022 at 2:23 PM Tom Tromey <tom@tromey.com> wrote:
> Thank you.  This is ok.

Thanks Tom. Pushed as commit 18694ad5bddc.

Aaron