From: Kevin Buettner via Gdb-patches <gdb-patches@sourceware.org>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdbsupport: simplify ptid_t::is_pid implementation
Date: Tue, 25 Jan 2022 16:53:18 -0700 [thread overview]
Message-ID: <20220125165318.4bb787b0@f35-zws-1> (raw)
In-Reply-To: <20220124214141.1571525-1-simon.marchi@polymtl.ca>
On Mon, 24 Jan 2022 16:41:41 -0500
Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> wrote:
> The current ptid_t::is_pid implementation makes more comparisons than
> necessary. We can simplify it to just check that the pid value is
> positive and the other two components are 0.
LGTM.
Kevin
prev parent reply other threads:[~2022-01-25 23:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 21:41 Simon Marchi via Gdb-patches
2022-01-25 23:53 ` Kevin Buettner via Gdb-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220125165318.4bb787b0@f35-zws-1 \
--to=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox