From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KHMEK4iN8GE3CAAAWB0awg (envelope-from ) for ; Tue, 25 Jan 2022 18:53:44 -0500 Received: by simark.ca (Postfix, from userid 112) id A0D981F3B6; Tue, 25 Jan 2022 18:53:44 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 28D741EE18 for ; Tue, 25 Jan 2022 18:53:44 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 486A4385ED40 for ; Tue, 25 Jan 2022 23:53:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 486A4385ED40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1643154823; bh=kAVf9vzxOiYEI+3tSki65I0eiGMWeUJtTXaiRYTMz9E=; h=Date:To:Subject:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=KsnJEoRWY9UFok6cV60dIjr5cgRC2PYvxlNTOE4uBDJhnH3p7TFxgMvFO3RVyjPRS uNg3C9ZsoFGstnUFbWTAr4HDr+qMuHQHjDp1pogQ/VaH2Txu4wKEP5aSA9gUNgkDpI lAJqlxTLgi8aPt7XhPSOZi9/8La21WjINaxECl4o= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 75601385380A for ; Tue, 25 Jan 2022 23:53:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 75601385380A Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-614-GohiD4cPNOChfvy9ixkwqw-1; Tue, 25 Jan 2022 18:53:21 -0500 X-MC-Unique: GohiD4cPNOChfvy9ixkwqw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D5AC68144E4; Tue, 25 Jan 2022 23:53:20 +0000 (UTC) Received: from f35-zws-1 (unknown [10.2.16.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DCE4A7B014; Tue, 25 Jan 2022 23:53:19 +0000 (UTC) Date: Tue, 25 Jan 2022 16:53:18 -0700 To: Simon Marchi via Gdb-patches Subject: Re: [PATCH] gdbsupport: simplify ptid_t::is_pid implementation Message-ID: <20220125165318.4bb787b0@f35-zws-1> In-Reply-To: <20220124214141.1571525-1-simon.marchi@polymtl.ca> References: <20220124214141.1571525-1-simon.marchi@polymtl.ca> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kevin Buettner via Gdb-patches Reply-To: Kevin Buettner Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Mon, 24 Jan 2022 16:41:41 -0500 Simon Marchi via Gdb-patches wrote: > The current ptid_t::is_pid implementation makes more comparisons than > necessary. We can simplify it to just check that the pid value is > positive and the other two components are 0. LGTM. Kevin