Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [committed][gdb/testsuite] Fix gdb.dwarf2/gdb-add-index-symlink.exp
@ 2021-10-11 10:28 Tom de Vries via Gdb-patches
  0 siblings, 0 replies; only message in thread
From: Tom de Vries via Gdb-patches @ 2021-10-11 10:28 UTC (permalink / raw)
  To: gdb-patches

Hi,

The test-case gdb.dwarf2/gdb-add-index-symlink.exp interpretes a failure to
add an index as a failure to add an index for a symlink:
...
if { [ensure_gdb_index $symlink] == -1 } {
    fail "Unable to call gdb-add-index with a symlink to a symfile"
    return -1
}
...

However, it's possible that the gdb-add-index also fails with a regular
file.  Add a check for that situation.

Tested on x86_64-linux.

Committed to trunk.

Thanks,
- Tom

[gdb/testsuite] Fix gdb.dwarf2/gdb-add-index-symlink.exp

---
 gdb/testsuite/gdb.dwarf2/gdb-add-index-symlink.exp | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/gdb/testsuite/gdb.dwarf2/gdb-add-index-symlink.exp b/gdb/testsuite/gdb.dwarf2/gdb-add-index-symlink.exp
index eaeddec0250..74c558ad231 100644
--- a/gdb/testsuite/gdb.dwarf2/gdb-add-index-symlink.exp
+++ b/gdb/testsuite/gdb.dwarf2/gdb-add-index-symlink.exp
@@ -22,6 +22,19 @@ if {![dwarf2_support]} {
 
 standard_testfile main.c
 
+# First check whether we can actually handle the non-symlink case.
+with_test_prefix non-symlink {
+    if { [prepare_for_testing "failed to prepare" "${testfile}" \
+	      [list ${srcfile}]] } {
+	return -1
+    }
+
+    if { [ensure_gdb_index $binfile] == -1 } {
+	return -1
+    }
+}
+
+# Regenerate exec without index.
 if { [prepare_for_testing "failed to prepare" "${testfile}" \
 	  [list ${srcfile}]] } {
     return -1

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-10-11 10:29 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-11 10:28 [committed][gdb/testsuite] Fix gdb.dwarf2/gdb-add-index-symlink.exp Tom de Vries via Gdb-patches

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox