[PATCH] [sim] Include defs.h in ppc/hw_memory.c

[PATCH] [sim] Include defs.h in ppc/hw_memory.c

[Christian Biesinger via Gdb-patches]

From: Christian Biesinger <cbiesinger@chromium.org>

To fix this error (seen on cygwin):
/../../sim/ppc/../common ../../../sim/ppc/hw_memory.c
In file included from ../../gnulib/import/stdlib.h:100,
                 from ../../../sim/ppc/hw_memory.c:28:
../../gnulib/import/unistd.h:663:3: error: #error "Please include config.h first."
  663 |  #error "Please include config.h first."
      |   ^~~~~
../../gnulib/import/unistd.h:665:24: error: expected ‘;’ before ‘extern’
  665 | _GL_INLINE_HEADER_BEGIN
      |                        ^
      |                        ;
../../gnulib/import/unistd.h:2806:22: error: expected ‘;’ before ‘extern’
 2806 | _GL_INLINE_HEADER_END
      |                      ^
      |                      ;
---
 sim/ppc/hw_memory.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sim/ppc/hw_memory.c b/sim/ppc/hw_memory.c
index 46b22f7b6e3..2376be6730b 100644
--- a/sim/ppc/hw_memory.c
+++ b/sim/ppc/hw_memory.c
@@ -25,6 +25,9 @@
 #define STATIC_INLINE_HW_MEMORY STATIC_INLINE
 #endif
 
+/* This must come before any other includes.  */
+#include "defs.h"
+
 #include <stdlib.h>
 
 #include "device_table.h"
-- 
2.33.0.882.g93a45727a2-goog

Re: [PATCH] [sim] Include defs.h in ppc/hw_memory.c

[Mike Frysinger via Gdb-patches]

[-- Attachment #1: Type: text/plain, Size: 57 bytes --]

lgtm, thanks

(if you need me to push, lemme know)
-mike

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] [sim] Include defs.h in ppc/hw_memory.c

[Christian Biesinger via Gdb-patches]

On Fri, Oct 8, 2021 at 9:16 PM Mike Frysinger <vapier@gentoo.org> wrote:
>
> lgtm, thanks
>
> (if you need me to push, lemme know)

I finally found my SSH key again and pushed this.

   d6dc01baf75..cf365c10d07  HEAD -> master

Christian