From: Andrew Burgess <andrew.burgess@embecosm.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdbsupport: remove attempt to define TARGET_WORD_SIZE
Date: Mon, 4 Oct 2021 11:24:11 +0100 [thread overview]
Message-ID: <20211004102411.GN1900093@embecosm.com> (raw)
In-Reply-To: <87lf3e0xqp.fsf@tromey.com>
Thanks for the reviews. I've pushed this patch now.
Andrew
* Tom Tromey <tom@tromey.com> [2021-09-30 11:38:54 -0600]:
> >>>>> "Pedro" == Pedro Alves <pedro@palves.net> writes:
>
> Pedro> Strange, that TARGET_WORD_SIZE bits was added by 01027315f540,
> Pedro> and AFAICS, git grep on 01027315f540^ only finds ChangeLog hits.
> Pedro> But it wasn't used anywhere when it was added by commit
> Pedro> 01027315f540 either.
>
> Pedro> Maybe Tromey remembers.
>
> I don't, sorry.
>
> Pedro> The patch LGTM.
>
> Me too.
>
> Tom
prev parent reply other threads:[~2021-10-04 10:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 16:44 Andrew Burgess
2021-09-24 16:54 ` Pedro Alves
2021-09-30 17:38 ` Tom Tromey
2021-10-04 10:24 ` Andrew Burgess [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211004102411.GN1900093@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox