From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id rYkRB1vWWmFmawAAWB0awg (envelope-from ) for ; Mon, 04 Oct 2021 06:24:27 -0400 Received: by simark.ca (Postfix, from userid 112) id 0C9E81EE1A; Mon, 4 Oct 2021 06:24:27 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 472631E4A3 for ; Mon, 4 Oct 2021 06:24:26 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C62EA385741D for ; Mon, 4 Oct 2021 10:24:25 +0000 (GMT) Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by sourceware.org (Postfix) with ESMTPS id 278F93858408 for ; Mon, 4 Oct 2021 10:24:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 278F93858408 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-wr1-x432.google.com with SMTP id r7so14382674wrc.10 for ; Mon, 04 Oct 2021 03:24:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=NtD8ni15hFxxY+l5yI5c11xPHDZM65oVyns3pn60aTk=; b=WZjyMUkQPjjOq85mHjKUawI7bvXmIq7yjXRyiRGgJ39M/T80C1wl1mZtyKBSfswB6q D7BERULdCuxX+l9lDwRrWAXakUUaEdoZImrrQI3Vi1DspBjaMmS8VBns7rfB5Q/8u12d ucZOeW1xStekrZN8od1VLoV5tfvT0iTNAG3ANlxs8YpqAr6z+kLym/qCapP8oV/cpVfx vCLpBXfU9vF2DyW36BxrPB2uf00dujFlSr/xuDXFehUe4NpsBkbV1aZPm3G9NBSAq766 4WmWDg5uDrT0m5AqZkayChSQx9eOSlWZGRec6Xmc9xqax8vC1vKNbjuJhqARs2LTiZte Q7tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=NtD8ni15hFxxY+l5yI5c11xPHDZM65oVyns3pn60aTk=; b=PDOR8XWhAsm8LtnzHnGQpJILkoS7mR0G7omhf4bfbkw1D+av6yupjulnt6pq/NyaTB mS9+JBjyOqmq7sZ1CP5os0c7lEZcQbCzxPDjwnIJBNLQArI/ZRhqAU0s50q5ltN7gQKO 2s8BqYwNOQuS+cK0lDvm01Q8e698LrcaAb34uzIKzLjz/XTYI4YBhnq6txtGcTclvtOD WLX6ZT0MIgZ/X0xYDanC4dqGu2+VwUyJYRDPoqXBpu11fqUtKekZiMkR9ldbPbRTrjKo mTmg3MfY/Kj1nGSpzafoFdgE5mYiceYox4Y9s6TAWMYPD0hTQ+FTOujDMrzyzIi6vazs 3uoA== X-Gm-Message-State: AOAM533rJIJnaVt8a0Fp4baNhYimPqYCJBY7QOOVVGA21KCCdqs/vdna ouTeeCyLXX8mfSvxpuOgdEqPWQ== X-Google-Smtp-Source: ABdhPJxhet+mJPmpa2Hv0GoGSgMsEgMlJrRwQHqxJp/DkXLIa2ZoTJ8r9lpmSf0QkyfYV8iixTb3+w== X-Received: by 2002:a5d:5510:: with SMTP id b16mr13433738wrv.112.1633343053027; Mon, 04 Oct 2021 03:24:13 -0700 (PDT) Received: from localhost (host86-169-137-11.range86-169.btcentralplus.com. [86.169.137.11]) by smtp.gmail.com with ESMTPSA id o15sm13811295wmc.21.2021.10.04.03.24.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Oct 2021 03:24:12 -0700 (PDT) Date: Mon, 4 Oct 2021 11:24:11 +0100 From: Andrew Burgess To: Tom Tromey Subject: Re: [PATCH] gdbsupport: remove attempt to define TARGET_WORD_SIZE Message-ID: <20211004102411.GN1900093@embecosm.com> References: <20210924164413.3770845-1-andrew.burgess@embecosm.com> <9bd5f5ea-aa2a-8829-cde0-d5697dab87c1@palves.net> <87lf3e0xqp.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87lf3e0xqp.fsf@tromey.com> X-Operating-System: Linux/5.8.18-100.fc31.x86_64 (x86_64) X-Uptime: 11:23:51 up 15 days, 1:32, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Thanks for the reviews. I've pushed this patch now. Andrew * Tom Tromey [2021-09-30 11:38:54 -0600]: > >>>>> "Pedro" == Pedro Alves writes: > > Pedro> Strange, that TARGET_WORD_SIZE bits was added by 01027315f540, > Pedro> and AFAICS, git grep on 01027315f540^ only finds ChangeLog hits. > Pedro> But it wasn't used anywhere when it was added by commit > Pedro> 01027315f540 either. > > Pedro> Maybe Tromey remembers. > > I don't, sorry. > > Pedro> The patch LGTM. > > Me too. > > Tom