[PATCH][gdb/symtab] Don't write .gdb_index symbol table with empty entries

[PATCH][gdb/symtab] Don't write .gdb_index symbol table with empty entries

[Tom de Vries via Gdb-patches]

Hi,

When comparing the sizes of the index files generated for shlib
outputs/gdb.dwarf2/dw2-zero-range/shr1.sl, I noticed a large difference
between .debug_names:
...
$ gdb -q -batch $shlib -ex "save gdb-index -dwarf-5 ."
$ du -b -h shr1.sl.debug_names shr1.sl.debug_str
61      shr1.sl.debug_names
0       shr1.sl.debug_str
...
and .gdb_index:
...
$ gdb -q -batch $shlib -ex "save gdb-index ."
$ du -b -h shr1.sl.gdb-index
8.2K    shr1.sl.gdb-index
...

The problem is that the .gdb_index contains a non-empty symbol table with only
empty entries.

Fix this by making the symbol table empty, such that we have instead:
...
$ du -b -h shr1.sl.gdb-index
184     shr1.sl.gdb-index
...

Tested on x86_64-linux.

Any comments?

Thanks,
- Tom

[gdb/symtab] Don't write .gdb_index symbol table with empty entries

---
 gdb/dwarf2/index-write.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gdb/dwarf2/index-write.c b/gdb/dwarf2/index-write.c
index 0fe2bc4dd05..0318b7a81b2 100644
--- a/gdb/dwarf2/index-write.c
+++ b/gdb/dwarf2/index-write.c
@@ -1385,6 +1385,9 @@ write_gdbindex (dwarf2_per_objfile *per_objfile, FILE *out_file,
   uniquify_cu_indices (&symtab);
 
   data_buf symtab_vec, constant_pool;
+  if (symtab.n_elements == 0)
+    symtab.data.resize (0);
+
   write_hash_table (&symtab, symtab_vec, constant_pool);
 
   write_gdbindex_1(out_file, objfile_cu_list, types_cu_list, addr_vec,

Re: [PATCH][gdb/symtab] Don't write .gdb_index symbol table with empty entries

[Tom Tromey]

>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:

Tom> The problem is that the .gdb_index contains a non-empty symbol table with only
Tom> empty entries.

Tom> Fix this by making the symbol table empty, such that we have instead:

Looks good, thank you for doing this.

Tom