Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org, andrew.burgess@embecosm.com,
	vapier@gentoo.org
Subject: [PATCH] sim: ppc: fix some Wpointer-sign warnings
Date: Wed, 19 May 2021 12:46:47 +0200	[thread overview]
Message-ID: <20210519104646.GA11845@delia> (raw)

Hi,

When compiling with --enable-werror and CFLAGS="-O0 -g -Wall", we run into:
...
src/sim/ppc/hw_memory.c: In function ‘hw_memory_init_address’:
src/sim/ppc/hw_memory.c:204:7: error: pointer targets in passing argument 4 \
  of ‘device_find_integer_array_property’ differ in signedness \
  [-Werror=pointer-sign]
       &new_chunk->size);
       ^
...

Fix these by adding an explicit pointer cast.

Any comments?

Thanks,
- Tom

sim: ppc: fix some Wpointer-sign warnings

---
 sim/ppc/hw_memory.c | 6 +++---
 sim/ppc/hw_opic.c   | 6 ++++--
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/sim/ppc/hw_memory.c b/sim/ppc/hw_memory.c
index 09c331c3295..c0826b71139 100644
--- a/sim/ppc/hw_memory.c
+++ b/sim/ppc/hw_memory.c
@@ -190,7 +190,7 @@ hw_memory_init_address(device *me)
   if (device_find_property(me, "available") != NULL) {
     hw_memory_chunk **curr_chunk = &hw_memory->heap;
     int cell_nr;
-    unsigned_cell dummy;
+    signed_cell dummy;
     int nr_cells = device_find_integer_array_property(me, "available", 0, &dummy);
     if ((nr_cells % 2) != 0)
       device_error(me, "property \"available\" invalid - contains an odd number of cells");
@@ -199,9 +199,9 @@ hw_memory_init_address(device *me)
 	 cell_nr += 2) {
       hw_memory_chunk *new_chunk = ZALLOC(hw_memory_chunk);
       device_find_integer_array_property(me, "available", cell_nr,
-					 &new_chunk->address);
+					 (signed_cell *)&new_chunk->address);
       device_find_integer_array_property(me, "available", cell_nr + 1,
-					 &new_chunk->size);
+					 (signed_cell *)&new_chunk->size);
       new_chunk->available = 1;
       *curr_chunk = new_chunk;
       curr_chunk = &new_chunk->next;
diff --git a/sim/ppc/hw_opic.c b/sim/ppc/hw_opic.c
index 8afe312a7ef..9404204aa2f 100644
--- a/sim/ppc/hw_opic.c
+++ b/sim/ppc/hw_opic.c
@@ -417,10 +417,12 @@ hw_opic_init_data(device *me)
       }
       if (!device_find_integer_array_property(me, "interrupt-ranges",
 					      reg_nr * 2,
-					      &opic->isu_block[isb].int_number)
+					      (signed_cell *)
+					        &opic->isu_block[isb].int_number)
 	  || !device_find_integer_array_property(me, "interrupt-ranges",
 						 reg_nr * 2 + 1,
-						 &opic->isu_block[isb].range))
+						 (signed_cell *)
+						   &opic->isu_block[isb].range))
 	device_error(me, "missing or invalid interrupt-ranges property entry %d", reg_nr);
       /* first reg entry specifies the address of both the IDU and the
          first set of ISU registers, adjust things accordingly */

             reply	other threads:[~2021-05-19 10:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-19 10:46 Tom de Vries [this message]
2021-05-19 16:32 ` Mike Frysinger via Gdb-patches
2021-05-20 11:59   ` Tom de Vries
2021-05-20 12:08   ` Tom de Vries
2021-09-09  3:17   ` Mike Frysinger via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210519104646.GA11845@delia \
    --to=tdevries@suse.de \
    --cc=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox