From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CElXEZ3spGCENgAAWB0awg (envelope-from ) for ; Wed, 19 May 2021 06:46:53 -0400 Received: by simark.ca (Postfix, from userid 112) id 4503F1F11C; Wed, 19 May 2021 06:46:53 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 94B4B1E01F for ; Wed, 19 May 2021 06:46:52 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 32BB6386FC37; Wed, 19 May 2021 10:46:52 +0000 (GMT) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id AD42F386FC1D for ; Wed, 19 May 2021 10:46:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AD42F386FC1D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D0440AE63; Wed, 19 May 2021 10:46:48 +0000 (UTC) Date: Wed, 19 May 2021 12:46:47 +0200 From: Tom de Vries To: gdb-patches@sourceware.org, andrew.burgess@embecosm.com, vapier@gentoo.org Subject: [PATCH] sim: ppc: fix some Wpointer-sign warnings Message-ID: <20210519104646.GA11845@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Hi, When compiling with --enable-werror and CFLAGS="-O0 -g -Wall", we run into: ... src/sim/ppc/hw_memory.c: In function ‘hw_memory_init_address’: src/sim/ppc/hw_memory.c:204:7: error: pointer targets in passing argument 4 \ of ‘device_find_integer_array_property’ differ in signedness \ [-Werror=pointer-sign] &new_chunk->size); ^ ... Fix these by adding an explicit pointer cast. Any comments? Thanks, - Tom sim: ppc: fix some Wpointer-sign warnings --- sim/ppc/hw_memory.c | 6 +++--- sim/ppc/hw_opic.c | 6 ++++-- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/sim/ppc/hw_memory.c b/sim/ppc/hw_memory.c index 09c331c3295..c0826b71139 100644 --- a/sim/ppc/hw_memory.c +++ b/sim/ppc/hw_memory.c @@ -190,7 +190,7 @@ hw_memory_init_address(device *me) if (device_find_property(me, "available") != NULL) { hw_memory_chunk **curr_chunk = &hw_memory->heap; int cell_nr; - unsigned_cell dummy; + signed_cell dummy; int nr_cells = device_find_integer_array_property(me, "available", 0, &dummy); if ((nr_cells % 2) != 0) device_error(me, "property \"available\" invalid - contains an odd number of cells"); @@ -199,9 +199,9 @@ hw_memory_init_address(device *me) cell_nr += 2) { hw_memory_chunk *new_chunk = ZALLOC(hw_memory_chunk); device_find_integer_array_property(me, "available", cell_nr, - &new_chunk->address); + (signed_cell *)&new_chunk->address); device_find_integer_array_property(me, "available", cell_nr + 1, - &new_chunk->size); + (signed_cell *)&new_chunk->size); new_chunk->available = 1; *curr_chunk = new_chunk; curr_chunk = &new_chunk->next; diff --git a/sim/ppc/hw_opic.c b/sim/ppc/hw_opic.c index 8afe312a7ef..9404204aa2f 100644 --- a/sim/ppc/hw_opic.c +++ b/sim/ppc/hw_opic.c @@ -417,10 +417,12 @@ hw_opic_init_data(device *me) } if (!device_find_integer_array_property(me, "interrupt-ranges", reg_nr * 2, - &opic->isu_block[isb].int_number) + (signed_cell *) + &opic->isu_block[isb].int_number) || !device_find_integer_array_property(me, "interrupt-ranges", reg_nr * 2 + 1, - &opic->isu_block[isb].range)) + (signed_cell *) + &opic->isu_block[isb].range)) device_error(me, "missing or invalid interrupt-ranges property entry %d", reg_nr); /* first reg entry specifies the address of both the IDU and the first set of ISU registers, adjust things accordingly */