From: Andrew Burgess <andrew.burgess@embecosm.com>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [pushed] Remove extra space after @pxref in gdb.texinfo
Date: Wed, 27 Jan 2021 14:06:52 +0000 [thread overview]
Message-ID: <20210127140652.GM265215@embecosm.com> (raw)
In-Reply-To: <20210127135733.2476752-1-tromey@adacore.com>
* Tom Tromey <tromey@adacore.com> [2021-01-27 06:57:33 -0700]:
> Internally at AdaCore, documentation is still built with Texinfo 4.13.
> This version gave an error when building gdb.texinfo:
>
> ../../../binutils-gdb/gdb/doc/gdb.texinfo:27672: @pxref expected braces.
> ../../../binutils-gdb/gdb/doc/gdb.texinfo:27672: ` {dotdebug_gdb_scripts section,,The @cod...' is too long for expansion; not expanded.
>
> ... followed by many more spurious errors that were caused by this
> one.
>
> This patch fix the problem by removing the extra space.
>
> I don't know whether it's advisable to try to support this ancient
> version of Texinfo (released in 2008 apparently); but in this
> particular case the fix is trivial, so I'm checking it in.
>
> gdb/doc/ChangeLog
> 2021-01-27 Tom Tromey <tromey@adacore.com>
>
> * gdb.texinfo (Auto-loading extensions): Remove extraneous
> * space.
Thanks for fixing this, and sorry for introducing the breakage.
Andrew
> ---
> gdb/doc/ChangeLog | 4 ++++
> gdb/doc/gdb.texinfo | 2 +-
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index e43819f0f70..84243a72eaf 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -27669,7 +27669,7 @@ extensions when a new object file is read (for example, due to the
> library): @file{@var{objfile}-gdb.@var{ext}} (@pxref{objfile-gdbdotext
> file,,The @file{@var{objfile}-gdb.@var{ext}} file}) and the
> @code{.debug_gdb_scripts} section of modern file formats like ELF
> -(@pxref {dotdebug_gdb_scripts section,,The @code{.debug_gdb_scripts}
> +(@pxref{dotdebug_gdb_scripts section,,The @code{.debug_gdb_scripts}
> section}). For a discussion of the differences between these two
> approaches see @ref{Which flavor to choose?}.
>
> --
> 2.26.2
>
prev parent reply other threads:[~2021-01-27 14:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 13:57 Tom Tromey
2021-01-27 14:06 ` Andrew Burgess [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210127140652.GM265215@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox