From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4uaqN4NzEWBJRgAAWB0awg (envelope-from ) for ; Wed, 27 Jan 2021 09:06:59 -0500 Received: by simark.ca (Postfix, from userid 112) id D61CF1EF80; Wed, 27 Jan 2021 09:06:59 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 80E271E590 for ; Wed, 27 Jan 2021 09:06:59 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CEE3F3892441; Wed, 27 Jan 2021 14:06:58 +0000 (GMT) Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by sourceware.org (Postfix) with ESMTPS id 5A78B389042C for ; Wed, 27 Jan 2021 14:06:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5A78B389042C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wr1-x42f.google.com with SMTP id m13so2015333wro.12 for ; Wed, 27 Jan 2021 06:06:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=9FMT7id8zg87ufAtjltRpXu4pwOQb2hC097i5nc8LQQ=; b=Ol0pVTu4i7G++FBjHC47MpHw+4sigATJr7JLnhj0hgW+LbGg2/ETxF07MMD+F0Mf0W iy5VzSlMwh6cKjCwW9ioQD/JEvetGL4Ik+sbzaroQ6fC8mQKOc0AHEklP5GNioa+qsy7 7SvkovdTB9SKkcYZOPyqS46jfhUvUQ7irKkQvdsLpcAUBs3HAga3goasBjyYxEc0JyD8 TsOmDnNmtzjpNTuug/C8PlLhO1IG/CbwiwF3lOATYTiUDAo9VVs7EinrYqA5WcoPMIow a8XcfljC4H/P4JlU7ZUXGKVKTvLOyRuowl7IHZ1SIc5hNJJPVvj8IlsJsOFcxbzAqW5f yVTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9FMT7id8zg87ufAtjltRpXu4pwOQb2hC097i5nc8LQQ=; b=soMzCYQMI/yFPo9hwTmDcp8/ckf85G2PH+amBeVQEbWtIOh6C94iw9IkISHpWihVBM b7eWnbtHzDopv1ThCLJx6ZwEl2xNFs9afBmkSvKYt2jgHSA0lj1EodVOUpnMDmUTh+yR uayeuW83T53QMmaJoHmXdIGw2pDZ/tXK4krW6CeVg2F84CN3Gdpdv86oH71v6n/8U8Dc LdD/cUF75oObpwG62jKovOh5L5dvO5QYKB97Q0SKcyG0/JvYN/HyOTAqYSbofU9AlOYc 0DJotdFx8dh0xa8GC8YKba/u9uRsJZA1648Vp4vDEuRmd08YTndCbyStrPc2Sh+TeZRa O/Lg== X-Gm-Message-State: AOAM531vpD8qUqp40403/5dp1Ys6LYCxihch63nY7LZZx3NIHJIDMPWE GXRE0hXRz3lG+OnCbnV32+YvHoOS/YbMqw== X-Google-Smtp-Source: ABdhPJx2QfubWgO8lfPshm43h2/ktbZjJAnTjyTArygAvkbTTOUn77i4cYZBzGhO9GJJfmPix4SK1w== X-Received: by 2002:adf:b257:: with SMTP id y23mr11199972wra.371.1611756414383; Wed, 27 Jan 2021 06:06:54 -0800 (PST) Received: from localhost (host86-166-129-180.range86-166.btcentralplus.com. [86.166.129.180]) by smtp.gmail.com with ESMTPSA id s24sm2609730wmh.22.2021.01.27.06.06.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jan 2021 06:06:53 -0800 (PST) Date: Wed, 27 Jan 2021 14:06:52 +0000 From: Andrew Burgess To: Tom Tromey Subject: Re: [pushed] Remove extra space after @pxref in gdb.texinfo Message-ID: <20210127140652.GM265215@embecosm.com> References: <20210127135733.2476752-1-tromey@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210127135733.2476752-1-tromey@adacore.com> X-Operating-System: Linux/5.8.13-100.fc31.x86_64 (x86_64) X-Uptime: 14:06:30 up 49 days, 18:50, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" * Tom Tromey [2021-01-27 06:57:33 -0700]: > Internally at AdaCore, documentation is still built with Texinfo 4.13. > This version gave an error when building gdb.texinfo: > > ../../../binutils-gdb/gdb/doc/gdb.texinfo:27672: @pxref expected braces. > ../../../binutils-gdb/gdb/doc/gdb.texinfo:27672: ` {dotdebug_gdb_scripts section,,The @cod...' is too long for expansion; not expanded. > > ... followed by many more spurious errors that were caused by this > one. > > This patch fix the problem by removing the extra space. > > I don't know whether it's advisable to try to support this ancient > version of Texinfo (released in 2008 apparently); but in this > particular case the fix is trivial, so I'm checking it in. > > gdb/doc/ChangeLog > 2021-01-27 Tom Tromey > > * gdb.texinfo (Auto-loading extensions): Remove extraneous > * space. Thanks for fixing this, and sorry for introducing the breakage. Andrew > --- > gdb/doc/ChangeLog | 4 ++++ > gdb/doc/gdb.texinfo | 2 +- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index e43819f0f70..84243a72eaf 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -27669,7 +27669,7 @@ extensions when a new object file is read (for example, due to the > library): @file{@var{objfile}-gdb.@var{ext}} (@pxref{objfile-gdbdotext > file,,The @file{@var{objfile}-gdb.@var{ext}} file}) and the > @code{.debug_gdb_scripts} section of modern file formats like ELF > -(@pxref {dotdebug_gdb_scripts section,,The @code{.debug_gdb_scripts} > +(@pxref{dotdebug_gdb_scripts section,,The @code{.debug_gdb_scripts} > section}). For a discussion of the differences between these two > approaches see @ref{Which flavor to choose?}. > > -- > 2.26.2 >