Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [PATCH][gdb/testsuite] Fix gdb.ada/out_of_line_in_inlined.exp with -m32 and gcc-10
@ 2021-01-26 18:03 Tom de Vries
  2021-01-27 20:49 ` Tom Tromey
  0 siblings, 1 reply; 2+ messages in thread
From: Tom de Vries @ 2021-01-26 18:03 UTC (permalink / raw)
  To: gdb-patches

Hi,

When running test-case gdb.ada/out_of_line_in_inlined.exp with target board
unix/-m32 on a system with gcc-10 default compiler, we run into:
...
(gdb) break foo_o224_021.child1.child2^M
Breakpoint 1 at 0x804ba59: foo_o224_021.child1.child2. (3 locations)^M
(gdb) FAIL: gdb.ada/out_of_line_in_inlined.exp: scenario=all: \
  break foo_o224_021.child1.child2
...

The test does not expect the "3 locations" part.

Fix this by using gdb_breakpoint instead of gdb_test.

Tested on x86_64-linux.

Any comments?

Thanks,
- Tom

[gdb/testsuite] Fix gdb.ada/out_of_line_in_inlined.exp with -m32 and gcc-10

gdb/testsuite/ChangeLog:

2021-01-26  Tom de Vries  <tdevries@suse.de>

	* gdb.ada/out_of_line_in_inlined.exp: Use gdb_breakpoint.

---
 gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp b/gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp
index f3c8fdcf919..fa8f04e4cb2 100644
--- a/gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp
+++ b/gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp
@@ -30,8 +30,7 @@ foreach_with_prefix scenario {all minimal} {
 
     clean_restart ${testfile}
 
-    gdb_test "break foo_o224_021.child1.child2" \
-	"Breakpoint \[0-9\]+ at.*: file .*foo_o224_021.adb, line \[0-9\]+."
+    gdb_breakpoint "foo_o224_021.child1.child2"
 
     gdb_run_cmd
     gdb_test "" \

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH][gdb/testsuite] Fix gdb.ada/out_of_line_in_inlined.exp with -m32 and gcc-10
  2021-01-26 18:03 [PATCH][gdb/testsuite] Fix gdb.ada/out_of_line_in_inlined.exp with -m32 and gcc-10 Tom de Vries
@ 2021-01-27 20:49 ` Tom Tromey
  0 siblings, 0 replies; 2+ messages in thread
From: Tom Tromey @ 2021-01-27 20:49 UTC (permalink / raw)
  To: Tom de Vries; +Cc: gdb-patches

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> gdb/testsuite/ChangeLog:

Tom> 2021-01-26  Tom de Vries  <tdevries@suse.de>

Tom> 	* gdb.ada/out_of_line_in_inlined.exp: Use gdb_breakpoint.

Thanks, this looks good to me.

Tom

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-01-27 20:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-26 18:03 [PATCH][gdb/testsuite] Fix gdb.ada/out_of_line_in_inlined.exp with -m32 and gcc-10 Tom de Vries
2021-01-27 20:49 ` Tom Tromey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox