Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [committed][gdb/testsuite] Require is_amd64_regs_target in gdb.base/disasm-optim.exp
Date: Tue, 12 Jan 2021 14:34:37 +0100	[thread overview]
Message-ID: <20210112133435.GA29284@delia> (raw)

Hi,

When running test-case gdb.base/disasm-optim.exp with target board unix/-m32,
we get:
...
 Running disasm-optim.exp ...
 gdb compile failed, disasm-optim.c: Assembler messages:
 disasm-optim.c:35: Error: bad register name `%rip)'
 disasm-optim.c:46: Error: bad register name `%rax)'
 disasm-optim.c:57: Error: bad register name `%rip)'

                 === gdb Summary ===

 # of untested testcases         1
...

Fix this by requiring is_amd64_regs_target instead of istarget
"x86_64-*-linux*".

Tested on x86_64-linux.

Committed to trunk.

Thanks,
- Tom

[gdb/testsuite] Require is_amd64_regs_target in gdb.base/disasm-optim.exp

gdb/testsuite/ChangeLog:

2021-01-12  Tom de Vries  <tdevries@suse.de>

	* gdb.base/disasm-optim.exp: Require is_amd64_regs_target.

---
 gdb/testsuite/gdb.base/disasm-optim.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.base/disasm-optim.exp b/gdb/testsuite/gdb.base/disasm-optim.exp
index 9acbbe86f15..ebb0d1f35f0 100644
--- a/gdb/testsuite/gdb.base/disasm-optim.exp
+++ b/gdb/testsuite/gdb.base/disasm-optim.exp
@@ -15,7 +15,7 @@
 
 # This test exercises disassemble /s with optimized and inlined code.
 
-if { ![istarget "x86_64-*-linux*"] } {
+if { ![is_amd64_regs_target] } {
     continue
 }
 

                 reply	other threads:[~2021-01-12 13:34 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210112133435.GA29284@delia \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox