From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 1E6EJnOl/V8IQgAAWB0awg (envelope-from ) for ; Tue, 12 Jan 2021 08:34:43 -0500 Received: by simark.ca (Postfix, from userid 112) id 8F2DD1EF7E; Tue, 12 Jan 2021 08:34:43 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=MAILING_LIST_MULTI,RDNS_NONE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 35A9C1E590 for ; Tue, 12 Jan 2021 08:34:43 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 18E52386EC7D; Tue, 12 Jan 2021 13:34:42 +0000 (GMT) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id C0E99386EC7D for ; Tue, 12 Jan 2021 13:34:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C0E99386EC7D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DEB9FABC4 for ; Tue, 12 Jan 2021 13:34:38 +0000 (UTC) Date: Tue, 12 Jan 2021 14:34:37 +0100 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [committed][gdb/testsuite] Require is_amd64_regs_target in gdb.base/disasm-optim.exp Message-ID: <20210112133435.GA29284@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Hi, When running test-case gdb.base/disasm-optim.exp with target board unix/-m32, we get: ... Running disasm-optim.exp ... gdb compile failed, disasm-optim.c: Assembler messages: disasm-optim.c:35: Error: bad register name `%rip)' disasm-optim.c:46: Error: bad register name `%rax)' disasm-optim.c:57: Error: bad register name `%rip)' === gdb Summary === # of untested testcases 1 ... Fix this by requiring is_amd64_regs_target instead of istarget "x86_64-*-linux*". Tested on x86_64-linux. Committed to trunk. Thanks, - Tom [gdb/testsuite] Require is_amd64_regs_target in gdb.base/disasm-optim.exp gdb/testsuite/ChangeLog: 2021-01-12 Tom de Vries * gdb.base/disasm-optim.exp: Require is_amd64_regs_target. --- gdb/testsuite/gdb.base/disasm-optim.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.base/disasm-optim.exp b/gdb/testsuite/gdb.base/disasm-optim.exp index 9acbbe86f15..ebb0d1f35f0 100644 --- a/gdb/testsuite/gdb.base/disasm-optim.exp +++ b/gdb/testsuite/gdb.base/disasm-optim.exp @@ -15,7 +15,7 @@ # This test exercises disassemble /s with optimized and inlined code. -if { ![istarget "x86_64-*-linux*"] } { +if { ![is_amd64_regs_target] } { continue }