Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [PATCH][gdb/testsuite] Handle missing xz in gdb.base/gnu-debugdata.exp
@ 2020-12-14  7:42 Tom de Vries
  2020-12-14 15:49 ` Tom Tromey
  0 siblings, 1 reply; 2+ messages in thread
From: Tom de Vries @ 2020-12-14  7:42 UTC (permalink / raw)
  To: gdb-patches

Hi,

When running test-case gdb.base/gnu-debugdata.exp on SLE-11, I run into:
...
FAIL: gdb.base/gnu-debugdata.exp: xz
...

The fact that xz is not installed does not mean there's a fail, merely that
the test is unsupported.

Fix this by detecting the "spawn failed" reply in run_on_host and issuing
UNSUPPORTED instead.

Tested on x86_64-linux.

Any comments?

Thanks,
- Tom

[gdb/testsuite] Handle missing xz in gdb.base/gnu-debugdata.exp

gdb/testsuite/ChangeLog:

2020-12-14  Tom de Vries  <tdevries@suse.de>

	PR testsuite/26963
	* lib/gdb.exp (run_on_host): Declare test unsupported if spawn fails.

---
 gdb/testsuite/lib/gdb.exp | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 071b5afa99..083589d895 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -7047,7 +7047,11 @@ proc run_on_host { test program args } {
  	return 0
     } else {
 	verbose -log "run_on_host failed: $output"
-	fail $test
+	if { $output == "spawn failed" } {
+	    unsupported $test
+	} else {
+	    fail $test
+	}
 	return -1
     }
 }

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH][gdb/testsuite] Handle missing xz in gdb.base/gnu-debugdata.exp
  2020-12-14  7:42 [PATCH][gdb/testsuite] Handle missing xz in gdb.base/gnu-debugdata.exp Tom de Vries
@ 2020-12-14 15:49 ` Tom Tromey
  0 siblings, 0 replies; 2+ messages in thread
From: Tom Tromey @ 2020-12-14 15:49 UTC (permalink / raw)
  To: Tom de Vries; +Cc: gdb-patches

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> [gdb/testsuite] Handle missing xz in gdb.base/gnu-debugdata.exp

Tom> gdb/testsuite/ChangeLog:

Tom> 2020-12-14  Tom de Vries  <tdevries@suse.de>

Tom> 	PR testsuite/26963
Tom> 	* lib/gdb.exp (run_on_host): Declare test unsupported if spawn fails.

Looks good.  Thank you.

Tom

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-12-14 15:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-14  7:42 [PATCH][gdb/testsuite] Handle missing xz in gdb.base/gnu-debugdata.exp Tom de Vries
2020-12-14 15:49 ` Tom Tromey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox