From: Joel Brobecker <brobecker@adacore.com>
To: Tom de Vries <tdevries@suse.de>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/testsuite] Handle ada in gdb_compile_shlib
Date: Sun, 13 Dec 2020 17:29:34 +0400 [thread overview]
Message-ID: <20201213132934.GB366101@adacore.com> (raw)
In-Reply-To: <20201207121942.GA14289@delia>
Hi Tom,
> The single test-case in the testsuite that creates an ada shared library is
> gdb.ada/catch_ex_std.exp.
>
> The test-case does use gdb_compile_shlib, but with a few tweaks that make sure
> things are properly handled for ada.
>
> Move the ada-specific code to gdb_compile_shlib, such that gdb_compile_sh can
> be used for ada shared libs without tweaks.
>
> Tested on x86_64-linux.
>
> Any comments?
>
> Thanks,
> - Tom
>
> [gdb/testsuite] Handle ada in gdb_compile_shlib
>
> gdb/testsuite/ChangeLog:
>
> 2020-12-07 Tom de Vries <tdevries@suse.de>
>
> * lib/gdb.exp (gdb_compile_shlib): Handle ada.
> * gdb.ada/catch_ex_std.exp: Use gdb_compile_shlib to compile from
> source to shared lib. Add ada to options.
It took me a while to review this patch, primarily because
part fo the previous code in the foreach look was a bit more
obscure than it needed to be. Your implementation make it
more understandable, in my opinion, so thank you for that.
The patch looks good to me. Thanks for the nice simplification
of the testcase!
--
Joel
prev parent reply other threads:[~2020-12-13 13:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 12:19 Tom de Vries
2020-12-13 13:29 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201213132934.GB366101@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox