From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id neKbGVcX1l/hLQAAWB0awg (envelope-from ) for ; Sun, 13 Dec 2020 08:29:59 -0500 Received: by simark.ca (Postfix, from userid 112) id 5B5F61F0AA; Sun, 13 Dec 2020 08:29:59 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=MAILING_LIST_MULTI,RDNS_NONE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1076D1E99A for ; Sun, 13 Dec 2020 08:29:59 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 61A2D385800A; Sun, 13 Dec 2020 13:29:58 +0000 (GMT) Received: from rock.gnat.com (rock.gnat.com [IPv6:2620:20:4000:0:a9e:1ff:fe9b:1d1]) by sourceware.org (Postfix) with ESMTP id 441C0385800A for ; Sun, 13 Dec 2020 13:29:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 441C0385800A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=brobecker@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 1FBA256072; Sun, 13 Dec 2020 08:29:40 -0500 (EST) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id zu3VdAB231Ox; Sun, 13 Dec 2020 08:29:40 -0500 (EST) Received: from float.home (localhost.localdomain [127.0.0.1]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPS id B57BE5606E; Sun, 13 Dec 2020 08:29:39 -0500 (EST) Received: by float.home (Postfix, from userid 1000) id CE7CAA1880; Sun, 13 Dec 2020 17:29:34 +0400 (+04) Date: Sun, 13 Dec 2020 17:29:34 +0400 From: Joel Brobecker To: Tom de Vries Subject: Re: [PATCH][gdb/testsuite] Handle ada in gdb_compile_shlib Message-ID: <20201213132934.GB366101@adacore.com> References: <20201207121942.GA14289@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201207121942.GA14289@delia> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Hi Tom, > The single test-case in the testsuite that creates an ada shared library is > gdb.ada/catch_ex_std.exp. > > The test-case does use gdb_compile_shlib, but with a few tweaks that make sure > things are properly handled for ada. > > Move the ada-specific code to gdb_compile_shlib, such that gdb_compile_sh can > be used for ada shared libs without tweaks. > > Tested on x86_64-linux. > > Any comments? > > Thanks, > - Tom > > [gdb/testsuite] Handle ada in gdb_compile_shlib > > gdb/testsuite/ChangeLog: > > 2020-12-07 Tom de Vries > > * lib/gdb.exp (gdb_compile_shlib): Handle ada. > * gdb.ada/catch_ex_std.exp: Use gdb_compile_shlib to compile from > source to shared lib. Add ada to options. It took me a while to review this patch, primarily because part fo the previous code in the foreach look was a bit more obscure than it needed to be. Your implementation make it more understandable, in my opinion, so thank you for that. The patch looks good to me. Thanks for the nice simplification of the testcase! -- Joel