From: Joel Brobecker <brobecker@adacore.com>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH 1/4] gdb: make discrete_position return optional
Date: Sun, 6 Dec 2020 09:38:35 +0400 [thread overview]
Message-ID: <20201206053835.GC321750@adacore.com> (raw)
In-Reply-To: <20201123162120.3778679-2-simon.marchi@efficios.com>
Me again, Simon,
I just noticed...
> gdb/ChangeLog:
>
> * ada-lang.c (ada_value_slice_from_ptr): Adjust.
> (ada_value_slice): Adjust.
> (pos_atr): Adjust.
> * gdbtypes.c (get_discrete_bounds): Adjust.
> (discrete_position): Return optional.
> * gdbtypes.h (discrete_position): Return optional.
>
> Change-Id: I758dbd8858b296ee472ed39ec35db1dbd624a5ae
... that you revision logs have the Change-Id: field, which I assume
was for when we were trying Gerrit out. Since it's no longer the case,
perhaps you might want to disconnect the hook that adds them
automatically?
--
Joel
next prev parent reply other threads:[~2020-12-06 5:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 16:21 [PATCH 0/4] Fix bug in value_subscript when range's high bound is not known Simon Marchi via Gdb-patches
2020-11-23 16:21 ` [PATCH 1/4] gdb: make discrete_position return optional Simon Marchi via Gdb-patches
2020-12-06 5:25 ` Joel Brobecker
2020-12-06 5:38 ` Joel Brobecker [this message]
2020-12-07 14:58 ` Simon Marchi via Gdb-patches
2020-12-08 3:06 ` Joel Brobecker
2020-12-08 11:41 ` Maciej W. Rozycki
2020-12-09 19:29 ` Simon Marchi via Gdb-patches
2020-12-09 19:53 ` Maciej W. Rozycki
2020-11-23 16:21 ` [PATCH 2/4] gdb: make get_discrete_bounds return bool Simon Marchi via Gdb-patches
2020-12-06 6:03 ` Joel Brobecker
2020-12-07 15:19 ` Simon Marchi via Gdb-patches
2020-11-23 16:21 ` [PATCH 3/4] gdb: split get_discrete_bounds in two Simon Marchi via Gdb-patches
2020-12-06 7:29 ` Joel Brobecker
2020-12-07 15:49 ` Simon Marchi via Gdb-patches
2020-11-23 16:21 ` [PATCH 4/4] gdb: fix value_subscript when array upper bound is not known Simon Marchi via Gdb-patches
2020-12-06 7:54 ` Joel Brobecker
2020-12-07 16:06 ` Simon Marchi via Gdb-patches
2020-12-08 3:14 ` Joel Brobecker
2020-12-09 18:50 ` Simon Marchi via Gdb-patches
2020-12-09 19:57 ` Simon Marchi via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201206053835.GC321750@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox