From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 40aJFGRuzF9RawAAWB0awg (envelope-from ) for ; Sun, 06 Dec 2020 00:38:44 -0500 Received: by simark.ca (Postfix, from userid 112) id 46EE91F0B8; Sun, 6 Dec 2020 00:38:44 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=MAILING_LIST_MULTI,RDNS_NONE autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 00CF51E99A for ; Sun, 6 Dec 2020 00:38:43 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 46E20385703F; Sun, 6 Dec 2020 05:38:43 +0000 (GMT) Received: from rock.gnat.com (rock.gnat.com [205.232.38.15]) by sourceware.org (Postfix) with ESMTP id E7961385703F for ; Sun, 6 Dec 2020 05:38:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E7961385703F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=brobecker@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id C7144116877; Sun, 6 Dec 2020 00:38:40 -0500 (EST) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id w3lWikAejvz5; Sun, 6 Dec 2020 00:38:40 -0500 (EST) Received: from float.home (localhost.localdomain [127.0.0.1]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPS id 676A81167D1; Sun, 6 Dec 2020 00:38:40 -0500 (EST) Received: by float.home (Postfix, from userid 1000) id 8C736A1880; Sun, 6 Dec 2020 09:38:35 +0400 (+04) Date: Sun, 6 Dec 2020 09:38:35 +0400 From: Joel Brobecker To: Simon Marchi via Gdb-patches Subject: Re: [PATCH 1/4] gdb: make discrete_position return optional Message-ID: <20201206053835.GC321750@adacore.com> References: <20201123162120.3778679-1-simon.marchi@efficios.com> <20201123162120.3778679-2-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201123162120.3778679-2-simon.marchi@efficios.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Me again, Simon, I just noticed... > gdb/ChangeLog: > > * ada-lang.c (ada_value_slice_from_ptr): Adjust. > (ada_value_slice): Adjust. > (pos_atr): Adjust. > * gdbtypes.c (get_discrete_bounds): Adjust. > (discrete_position): Return optional. > * gdbtypes.h (discrete_position): Return optional. > > Change-Id: I758dbd8858b296ee472ed39ec35db1dbd624a5ae ... that you revision logs have the Change-Id: field, which I assume was for when we were trying Gerrit out. Since it's no longer the case, perhaps you might want to disconnect the hook that adds them automatically? -- Joel